Summary: | [DRT] Assertion failed when drag and move a draggable element. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
Component: | Tools / Tests | Assignee: | Hajime Morrita <morrita> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 39725 | ||||||||
Attachments: |
|
Description
Hajime Morrita
2010-07-06 06:37:22 PDT
Created attachment 60629 [details]
patch v0
Hi Eric, could you review this? All tests are passed. Comment on attachment 60629 [details] patch v0 The code looks fine, just some small style nits. > diff --git a/LayoutTests/fast/events/dragging-mouse-moves.html b/LayoutTests/fast/events/dragging-mouse-moves.html > + <style> * { margin: 0px; padding: 0px; } </style> > + <script> > + function log(msg) > + { The code is indented a strange amount here. Maybe line it up with the <script> tag? > + if (window.layoutTestController) { > + layoutTestController.waitUntilDone(); > + layoutTestController.dumpAsText(); > + testDragAndMove(); > + } It would be nice to have a message saying this test requires DRT if !window.layoutTestController. > + eventSender.mouseMoveTo(startX,startY); > + eventSender.mouseDown(); > + // Them drag it. OK not to crash. Grammar nit: "Then drag it." > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > + mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started. > + But Cocoa doesn't call mouseDragged() untill dragging is done. Spelling: until > + Other part of DumpRenderTree also assumes Cocoa behaviour and an assertion Spelling/Grammar: behavior (to use the US spelling) > + on UIDelegate failed when mouseDragged() is called dudring dragging. Spelling: during Committed r64643: <http://trac.webkit.org/changeset/64643> |