Bug 41659

Summary: Implement bookmarking for HTML5 Adoption Agency algorithm
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch abarth: review+, abarth: commit-queue-

Description Eric Seidel (no email) 2010-07-06 00:21:39 PDT 
Implement bookmarking for HTML5 Adoption Agency algorithm
Comment 1 Eric Seidel (no email) 2010-07-06 00:23:37 PDT 
Created attachment 60596 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-06 00:26:44 PDT 
Attachment 60596 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3403276
Comment 3 Adam Barth 2010-07-06 00:30:06 PDT 
Comment on attachment 60596 [details]
Patch

Your patch needs some work.  :)
Comment 4 Eric Seidel (no email) 2010-07-06 01:06:48 PDT 
Created attachment 60601 [details]
Patch
Comment 5 Eric Seidel (no email) 2010-07-06 01:07:16 PDT 
Yay for fixing 11 tests!
Comment 6 Adam Barth 2010-07-06 01:10:28 PDT 
Comment on attachment 60601 [details]
Patch

Awesome test progression.  :)

WebCore/html/HTMLFormattingElementList.cpp:140
 +              // Bookmarks are not general purpose, only for Adoption Agency.
This isn't really proper english...
Comment 7 Eric Seidel (no email) 2010-07-06 01:17:10 PDT 
Committed r62537: <http://trac.webkit.org/changeset/62537>
Comment 8 WebKit Review Bot 2010-07-06 01:39:32 PDT 
http://trac.webkit.org/changeset/62537 might have broken Qt Linux Release
Comment 9 Eric Seidel (no email) 2010-07-06 01:54:57 PDT 
Committed r62539: <http://trac.webkit.org/changeset/62539>