Bug 41659

Summary: Implement bookmarking for HTML5 Adoption Agency algorithm
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch abarth: review+, abarth: commit-queue-

Eric Seidel (no email)
Reported 2010-07-06 00:21:39 PDT
Implement bookmarking for HTML5 Adoption Agency algorithm
Attachments
Patch (10.06 KB, patch)
2010-07-06 00:23 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (15.69 KB, patch)
2010-07-06 01:06 PDT, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-06 00:23:37 PDT
Created attachment 60596 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-06 00:26:44 PDT
Attachment 60596 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/3403276
Adam Barth
Comment 3 2010-07-06 00:30:06 PDT
Comment on attachment 60596 [details] Patch Your patch needs some work. :)
Eric Seidel (no email)
Comment 4 2010-07-06 01:06:48 PDT
Created attachment 60601 [details] Patch
Eric Seidel (no email)
Comment 5 2010-07-06 01:07:16 PDT
Yay for fixing 11 tests!
Adam Barth
Comment 6 2010-07-06 01:10:28 PDT
Comment on attachment 60601 [details] Patch Awesome test progression. :) WebCore/html/HTMLFormattingElementList.cpp:140 + // Bookmarks are not general purpose, only for Adoption Agency. This isn't really proper english...
Eric Seidel (no email)
Comment 7 2010-07-06 01:17:10 PDT
Committed r62537: <http://trac.webkit.org/changeset/62537>
WebKit Review Bot
Comment 8 2010-07-06 01:39:32 PDT
http://trac.webkit.org/changeset/62537 might have broken Qt Linux Release
Eric Seidel (no email)
Comment 9 2010-07-06 01:54:57 PDT
Committed r62539: <http://trac.webkit.org/changeset/62539>
Note You need to log in before you can comment on or make changes to this bug.