Bug 41657

Summary: QWebSettings leaks pixmaps at program end on X11
Product: WebKit Reporter: marc
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Proposed fix none

Description marc 2010-07-06 00:19:23 PDT
On X11, when ending an application that used QtWebKit, I get an error message:
> ~QX11PixmapData(): QPixmap objects must be destroyed before the QApplication object, otherwise the native pixmap object will be leaked.
Comment 1 marc 2010-07-06 00:26:11 PDT
Created attachment 60599 [details]
Proposed fix
Comment 2 Adam Barth 2010-07-07 03:25:32 PDT
Comment on attachment 60599 [details]
Proposed fix

Thanks for the informative ChangeLog.  I'm not a Qt expert, but this change is convincing.  Too bad memory leaks are hard to test...
Comment 3 marc 2010-07-07 03:38:20 PDT
Apparently, the warning is bogus, and removed in the upcoming Qt 4.7. Still, the change doesn't hurt, and avoids the warning on older Qt's, too.
Comment 4 WebKit Commit Bot 2010-07-07 04:39:30 PDT
Comment on attachment 60599 [details]
Proposed fix

Clearing flags on attachment: 60599

Committed r62652: <http://trac.webkit.org/changeset/62652>
Comment 5 WebKit Commit Bot 2010-07-07 04:39:35 PDT
All reviewed patches have been landed.  Closing bug.