Summary: | Implement performance.navigation.type | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||||
Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dglazkov | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 30685 | ||||||||||
Attachments: |
|
Description
Tony Gentilcore
2010-07-02 22:30:14 PDT
Created attachment 60440 [details]
Patch
Comment on attachment 60440 [details]
Patch
WebCore/page/Navigation.h:56
+ NAVIGATE = 0,
Enum convention is CamelCase. Other than that, the baby's starting to take its first steps!
Created attachment 60751 [details]
Patch for landing
Comment on attachment 60751 [details] Patch for landing Rejecting patch 60751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 19306 test cases. fast/dom/navigation-type-back-forward.html -> failed Exiting early after 1 failures. 6430 tests run. 103.81s total testing time 6429 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://webkit-commit-queue.appspot.com/results/3480011 Created attachment 60894 [details]
Patch for landing
Comment on attachment 60894 [details] Patch for landing Clearing flags on attachment: 60894 Committed r62947: <http://trac.webkit.org/changeset/62947> All reviewed patches have been landed. Closing bug. |