Bug 41548

Summary: Use snprintf instead of sprintf everywhere in JavaScriptCore
Product: WebKit Reporter: Sam Weinig <sam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ggaren: review+, darin: commit-queue-

Sam Weinig
Reported 2010-07-02 16:23:28 PDT
Use snprintf instead of sprintf everywhere in JavaScriptCore.
Attachments
Patch (2.65 KB, patch)
2010-07-02 16:24 PDT, Sam Weinig 		ggaren: review+
darin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-02 16:24:23 PDT
Created attachment 60417 [details] Patch
Geoffrey Garen
Comment 2 2010-07-02 16:25:29 PDT
Comment on attachment 60417 [details] Patch r=me
Sam Weinig
Comment 3 2010-07-02 16:27:11 PDT
Landed in r62414.
Darin Adler
Comment 4 2010-07-02 16:28:26 PDT
Comment on attachment 60417 [details] Patch JSGlobalObjectFunctions.cpp includes <string.h>, but now that it's using snprintf I think it needs to include StringExtras.h instead to avoid breaking the Windows build. review+ if you fix that. Also: UString::from(long long) uses snprintf, and for some reason passes sizeof(minBuf) - 1. WTF is up with that? And: UString.cpp seems to include StringExtras.h twice and also includes <string.h> unnecessarily since StringExtras.h includes that.
Note You need to log in before you can comment on or make changes to this bug.