Bug 41522 – GTK build fails when [Conditional=FEATURE] tags used in .idl

• Component: Tools / Tests
• Status: RESOLVED FIXED

[John Gregg]

If a IDL file uses the [Conditional=FEATURE] tag on a specific attribute, the GTK build fails.

Example patch (see bug 40872)

Index: WebCore/html/File.idl
===================================================================
--- WebCore/html/File.idl	(revision 62339)
+++ WebCore/html/File.idl	(working copy)
@@ -30,6 +30,7 @@ module html {
         GenerateToJS
     ] File : Blob {
         readonly attribute DOMString name;
+        readonly attribute [Conditional=DIRECTORY_UPLOAD] DOMString path;
 
         // FIXME: obsolete attributes. To be removed.
         readonly attribute DOMString fileName;
Index: WebCore/html/HTMLInputElement.idl
===================================================================
--- WebCore/html/HTMLInputElement.idl	(revision 62339)
+++ WebCore/html/HTMLInputElement.idl	(working copy)
@@ -40,6 +40,7 @@ module html {
         attribute long maxLength setter raises(DOMException);
         attribute [Reflect] DOMString min;
         attribute [Reflect] boolean multiple;
+        attribute [Reflect, Conditional=DIRECTORY_UPLOAD] boolean webkitdirectory;
         attribute [Reflect] DOMString name;
         attribute [Reflect] DOMString pattern;
         attribute [Reflect] DOMString placeholder;

Generated these errors:

In file included from ./DerivedSources/webkit/webkitdom.h:49,
                 from ../../WebKit/gtk/webkit/webkit.h:26,
                 from ../../WebKitTools/GtkLauncher/main.c:28:
./DerivedSources/webkit/WebKitDOMFile.h:52:5: warning: "ENABLE" is not defined
./DerivedSources/webkit/WebKitDOMFile.h:52:11: error: missing binary operator before token "("
In file included from ./DerivedSources/webkit/webkitdom.h:80,
                 from ../../WebKit/gtk/webkit/webkit.h:26,
                 from ../../WebKitTools/GtkLauncher/main.c:28:
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:163:5: warning: "ENABLE" is not defined
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:163:11: error: missing binary operator before token "("
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:168:5: warning: "ENABLE" is not defined
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:168:11: error: missing binary operator before token "("

Full results here:
https://webkit-commit-queue.appspot.com/results/3350339

[Xan Lopez]

The problem is that someone patched the GObject script to add #if ENABLE() to the public GObject DOM bindings headers. I don't think this is right...

[Jian Li]

(In reply to comment #1)
> The problem is that someone patched the GObject script to add #if ENABLE() to the public GObject DOM bindings headers. I don't think this is right...

Yes, I am going to fix this. Thanks.

[Eric Seidel (no email)]

Is this still an issue?

[Martin Robinson]

I don't think this is still an issue.