| Summary: | Computed style is not implemented for padding-start, padding-end, margin-start, margin-end | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||||
| Component: | CSS | Assignee: | Erik Arvidsson <arv> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Minor | CC: | bdakin, commit-queue, dglazkov, hamaji, hyatt, mitz, ojan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 25761 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Erik Arvidsson
2010-07-01 17:44:55 PDT
Created attachment 60999 [details]
Patch
I wasn't sure where to put the helper function, resolveDirectionAwareProperty. Suggestions welcome. Comment on attachment 60999 [details]
Patch
I’m a little worried that the serialized form of all CSS properties will include redundant values and that will be some sort of problems. THe same value as both margin-left and margin-start, for example. Clearly when getting one particular property this is right.
WebCore/ChangeLog:9
+ (WebCore::):
Please avoid adding lines like this to ChangeLog.
(In reply to comment #3) > (From update of attachment 60999 [details]) > I’m a little worried that the serialized form of all CSS properties will include redundant values and that will be some sort of problems. THe same value as both margin-left and margin-start, for example. Clearly when getting one particular property this is right. Fair point. I also see that we do not include shorthands in this list. I'll remove the direction aware properties from computedProperties. Created attachment 61113 [details]
Patch for landing
Comment on attachment 61113 [details] Patch for landing Clearing flags on attachment: 61113 Committed r63038: <http://trac.webkit.org/changeset/63038> All reviewed patches have been landed. Closing bug. |