Bug 4147

Summary: Array.toString() and toLocaleString() improvements from KDE KJS
Product: WebKit Reporter: Harri Porten <porten>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 94688    
Attachments:
Description Flags
Patch
none
fast/js/toString-overrides.html none

Description Harri Porten 2005-07-26 15:12:47 PDT
I have problems reaching KDE's websvn server so I'm posting patches by linking  
to the CVS mail archive:  
  
The tests I added in  
   
 http://lists.kde.org/?l=kde-commits&m=112241237705027&w=2  
  
demonstrate a set of problems that the current JSC (and also KDE's previous)  
implementation of Array.toString() and toLocaleString() has. The patch I added  
  
 http://lists.kde.org/?l=kde-commits&m=112241230116304&w=2 
 
tries to implement the behavior as I understand it. Maybe there's more to it. 
Could well be that the code should be factored out. 
 
Would appreciate if possible changes to the patch would be fed back to KDE. 
Thanks.
Comment 1 Geoffrey Garen 2005-07-27 16:52:41 PDT
Created attachment 3123 [details]
Patch

Uploaded JSC patch.
Comment 2 Geoffrey Garen 2005-07-27 16:53:28 PDT
Created attachment 3124 [details]
fast/js/toString-overrides.html

Uploaded layout test.