Bug 41459

Summary: Improve the main lexer switch by mapping input characters to their type
Product: WebKit Reporter: Zoltan Herczeg <zherczeg>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch oliver: review+

Zoltan Herczeg
Reported 2010-07-01 05:26:33 PDT
The array can be used for other purposes as well. SunSpider: no cahnge Parse-only tests: TEST COMPARISON FROM TO DETAILS ============================================================================= ** TOTAL **: 1.025x as fast 33.1ms +/- 1.9% 32.3ms +/- 1.1% significant ============================================================================= jquery: ?? 5.0ms +/- 0.0% 5.1ms +/- 4.4% not conclusive: might be *1.020x as slow* 1.3.2: ?? 5.0ms +/- 0.0% 5.1ms +/- 4.4% not conclusive: might be *1.020x as slow* mootools: - 5.3ms +/- 6.5% 5.1ms +/- 4.4% 1.2.2-core-nc: - 5.3ms +/- 6.5% 5.1ms +/- 4.4% prototype: - 6.3ms +/- 5.5% 6.1ms +/- 3.7% 1.6.0.3: - 6.3ms +/- 5.5% 6.1ms +/- 3.7% concat: 1.031x as fast 16.5ms +/- 2.3% 16.0ms +/- 0.0% significant jquery-mootools-prototype: 1.031x as fast 16.5ms +/- 2.3% 16.0ms +/- 0.0% significant
Attachments
patch (19.88 KB, patch)
2010-07-01 05:29 PDT, Zoltan Herczeg 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Herczeg
Comment 1 2010-07-01 05:29:26 PDT
Created attachment 60225 [details] patch
Oliver Hunt
Comment 2 2010-07-01 12:09:11 PDT
Comment on attachment 60225 [details] patch r=me
Zoltan Herczeg
Comment 3 2010-07-01 23:30:48 PDT
Landed in http://trac.webkit.org/changeset/62366 Closing bug.
Note You need to log in before you can comment on or make changes to this bug.