Bug 41437 – Add interface for network platform to pass up timing information

• Component: New Bugs
• Status: RESOLVED FIXED

[Tony Gentilcore]

Add interface for network platform to pass up timing information

[Tony Gentilcore]

Created attachment 60183 [details]
Patch

[Adam Barth]

Comment on attachment 60183 [details]
Patch

Why a RefPtr and not an OwnPtr?  I didn't see any sharing, but I might have missed it.

WebCore/platform/network/ResourceLoadTiming.h:44
 +          RefPtr<ResourceLoadTiming> timing(create());
we usually use the = form

[Tony Gentilcore]

(In reply to comment #2)
> (From update of attachment 60183 [details])
> Why a RefPtr and not an OwnPtr?  I didn't see any sharing, but I might have missed it.

ResourceResponseBase is copyable, but OwnPtr is not. So it can't have OwnPtr members. This patch follows the pattern of FormData on ResourceRequestBase.

> 
> WebCore/platform/network/ResourceLoadTiming.h:44
>  +          RefPtr<ResourceLoadTiming> timing(create());
> we usually use the = form

OK

[Adam Barth]

Comment on attachment 60183 [details]
Patch

Ah, thanks.  I'm not 100% clear on the motivation for this change, but the code itself looks fine.

[Tony Gentilcore]

(In reply to comment #4)
> (From update of attachment 60183 [details])
> Ah, thanks.  I'm not 100% clear on the motivation for this change, but the code itself looks fine.

I'm implementing: http://dev.w3.org/2006/webapi/WebTiming/

Some of the timings can be measures solely in WebKit. Those are in https://bugs.webkit.org/show_bug.cgi?id=41332

The rest of the timings have to be passed up from the network platform. That is what this is for.

[Tony Gentilcore]

Created attachment 60192 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 60192 [details]
Patch for landing

Rejecting patch 60192 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
hing file WebCore/WebCore.vcproj/WebCore.vcproj
patching file WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #2 succeeded at 7972 (offset 2 lines).
Hunk #3 succeeded at 12041 (offset 4 lines).
Hunk #4 FAILED at 19668.
1 out of 4 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file WebCore/platform/network/ResourceLoadTiming.h
patching file WebCore/platform/network/ResourceResponseBase.cpp
patching file WebCore/platform/network/ResourceResponseBase.h

Full output: http://webkit-commit-queue.appspot.com/results/3373083

[Tony Gentilcore]

Created attachment 60267 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 60267 [details]
Patch for landing

Clearing flags on attachment: 60267

Committed r62348: <http://trac.webkit.org/changeset/62348>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.