Bug 41385

Summary:

[chromium] Make the user script API static.

Product:

WebKit

Reporter:

Aaron Boodman <aa>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dglazkov, fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Aaron Boodman

Reported 2010-06-29 17:49:06 PDT

In Chromium, we want to push user scripts down into webcore prior to having a WebView instance. Since these methods are modifying global state, it is more convenient if they are static.

Attachments
Patch (4.93 KB, patch) 2010-06-29 18:03 PDT, Aaron Boodman	no flags	Details Formatted Diff Diff
Patch (4.94 KB, patch) 2010-06-29 18:14 PDT, Aaron Boodman	no flags	Details Formatted Diff Diff
Patch for landing (5.92 KB, patch) 2010-06-30 17:57 PDT, Aaron Boodman	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aaron Boodman

Comment 1 2010-06-29 18:03:56 PDT

Created attachment 60074 [details] Patch

Aaron Boodman

Comment 2 2010-06-29 18:14:28 PDT

Created attachment 60075 [details] Patch

Adam Barth

Comment 3 2010-06-29 18:18:04 PDT

Comment on attachment 60075 [details] Patch Looks good to me, but we need fishd here.

WebKit Review Bot

Comment 4 2010-06-29 18:46:44 PDT

Attachment 60075 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3373026

Darin Fisher (:fishd, Google)

Comment 5 2010-06-30 10:03:49 PDT

Comment on attachment 60075 [details] Patch WebKit/chromium/src/WebViewImpl.cpp:1976 + Vector<String>* patterns = new Vector<String>; nit: use OwnPtr here? WebKit/chromium/src/WebViewImpl.cpp:1988 + Vector<String>* patterns = new Vector<String>; nit: use OwnPtr here? i realize that your code is correct, but if someone ever added an early return it would suddenly start leaking memory. plus, i was only able to convince myself that your code was safe by checking the signature of addUser{Script,StyleSheet}ToWorld to see that it takes a PassOwnPtr parameter. r=me otherwise

Darin Fisher (:fishd, Google)

Comment 6 2010-06-30 10:04:34 PDT

one other nit, please put the term DEPRECATED in your FIXME comment about the removal of those non-static methods. that way it is easy to find deprecated stuff in the future.

Aaron Boodman

Comment 7 2010-06-30 17:57:52 PDT

Created attachment 60176 [details] Patch for landing

WebKit Commit Bot

Comment 8 2010-07-01 00:53:39 PDT

Comment on attachment 60176 [details] Patch for landing Clearing flags on attachment: 60176 Committed r62234: <http://trac.webkit.org/changeset/62234>

WebKit Commit Bot

Comment 9 2010-07-01 00:53:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.