| Summary: | REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Craig Post <sirgwain> | ||||||||
| Component: | DOM | Assignee: | Eric Seidel (no email) <eric> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, ap, commit-queue, eric, hsivonen | ||||||||
| Priority: | P1 | Keywords: | NeedsReduction, Regression | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac (Intel) | ||||||||||
| OS: | OS X 10.6 | ||||||||||
| URL: | http://money.cnn.com | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 41115 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 60049 [details]
Screenshot of CNN Money in Safari 5
(In reply to comment #2) > I cannot reproduce this with r62241 nightly. I just tested this out with Safari Version 5.0 (6533.16, r62241) and I'm still seeing it. Ah, I see the issue. I have the AdBlock extension installed. When I disable AdBlock it renders fine. However, it renders fine in base Safari 5 with AdBlock enabled. I can reproduce this with AdBlock 2.0.9 <http://safariadblock.com/> installed. This problem started with <http://trac.webkit.org/changeset/61285>, and only occurs with HTML5 parser enabled. Thank you for the report. The validator wasn't much help: http://html5.validator.nu/?doc=http://money.cnn.com/ obviously the site isn't valid HTML. The Safari extension is a xar archive, so "xar -x -f AdBlockForSafari.safariextz" will extract it. I suspect this is another <tag<foo> issue, but it's hard to know what the extension might be doing. Eric, can you figure out the root cause here? Thanks. Happy to look. I won't get a chance to spend any time on this until wednesday when I'm back from vacation though. Probably the same as this mozilla issue: Having -- > terminate comments breaks CNN Money https://bugzilla.mozilla.org/show_bug.cgi?id=570309 I'm going to try matching the Firefox behavior here. Created attachment 67107 [details]
Patch
Comment on attachment 67107 [details]
Patch
LGTM. THanks.
Comment on attachment 67107 [details] Patch Rejecting patch 67107 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20970 test cases. animations/combo-transform-translate+scale.html -> failed Exiting early after 1 failures. 99 tests run. 27.56s total testing time 98 test cases (98%) succeeded 1 test case (1%) had incorrect layout Full output: http://queues.webkit.org/results/3955353 > animations/combo-transform-translate+scale.html -> failed
Seems unlikely.
Comment on attachment 67107 [details]
Patch
Flaky test, I suspect.
Comment on attachment 67107 [details] Patch Clearing flags on attachment: 67107 Committed r67233: <http://trac.webkit.org/changeset/67233> All reviewed patches have been landed. Closing bug. |
Created attachment 60048 [details] Screenshot of Webkit Nightly build view of CNN money Browsing to money.cnn.com shows some funky layout. Picture attached.