Bug 41366 – [QT][S60] QGraphicsWebView based plugin crashes while destroying

• Component: WebKit Qt
• Status: RESOLVED DUPLICATE

[Mahesh Kulkarni]

Double deletion of PluginContainerSymbian causes crash while destroying the plugin on symbian phone. This is noticed only on QGraphicsWebView. 

Documentation from http://doc.trolltech.com/4.6.2/qgraphicsproxywidget.html

"QGraphicsProxyWidget shares ownership with QWidget, so if either of the two widgets are destroyed, the other widget will be automatically destroyed as well."

[Mahesh Kulkarni]

Created attachment 60042 [details]
proposed fix

No need to delete proxy separately as deleting any widget deletes both proxy and qwidget.

[Yael]

This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior.
Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget.
Abhinav is preparing a patch for that.

[Mahesh Kulkarni]

Comment on attachment 60042 [details]
proposed fix

fix for this bug is checked in as part of https://bugs.webkit.org/show_bug.cgi?id=37303

Obsoleting the bug and closing the bug

[Mahesh Kulkarni]

*** This bug has been marked as a duplicate of bug 37303 ***

[Yael]

(In reply to comment #2)
> This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior.
> Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget.
> Abhinav is preparing a patch for that.

Actually, the above comment is not true. Abhinav & I checked the code of QGraphicsProxyWidget and found that the proxy widget would have been deleted togather with the container. Sorry for the wrong comment :-)

[Mahesh Kulkarni]

(In reply to comment #5)
> (In reply to comment #2)
> > This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior.
> > Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget.
> > Abhinav is preparing a patch for that.
> 
> Actually, the above comment is not true. Abhinav & I checked the code of QGraphicsProxyWidget and found that the proxy widget would have been deleted togather with the container. Sorry for the wrong comment :-)

NP :) 
IMO either container or proxy deletion results in deletion of both by which we could avoid an extra check.