unicode-range property only with a descending range causes a crash

• Component: CSS
• Status: RESOLVED FIXED

[Yuzo Fujishima]

http://dev.w3.org/csswg/css3-fonts/#unicode-range-desc says:
    ... interval ranges that descend (e.g. U+400-32f) are invalid and omitted rather than treated as parse errors
    ... Without any valid ranges, the descriptor is omitted.

It follows that in the following example unicode-range must be omitted:
    @font-face {
        font-family: 'myfont';
        src: local('Arial');
        unicode-range: U+062-60;
    }

But as of r62096, opening a file containing the above rule results in a crash.

[Yuzo Fujishima]

Created attachment 59998 [details]
Testcase -- causes a crash

[Yuzo Fujishima]

Created attachment 60007 [details]
Fix for Bug 41339 - unicode-range property only with a descending range causes

Comment on attachment 60007 [details]
Fix for Bug 41339 - unicode-range property only with a descending range causes

Can this be tested with a text-only test using getComputedStyle or the CSSOM?

[Yuzo Fujishima]

Created attachment 60086 [details]
Addressed review comment. Test by JavaScript.

[Yuzo Fujishima]

Hi, mitz,

Thank you for the review.

(In reply to comment #3)
> (From update of attachment 60007 [details])
> Can this be tested with a text-only test using getComputedStyle or the CSSOM?

I tried but I couldn't find a way to retrieve the actual font name.
(I can get 'myfont' but not 'Arial' in the above example).

Instead, I used a monospace font and compare the width of two spans.
I believe it is good enough for this test.

(In reply to comment #5)
> Hi, mitz,
> 
> Thank you for the review.
> 
> (In reply to comment #3)
> > (From update of attachment 60007 [details] [details])
> > Can this be tested with a text-only test using getComputedStyle or the CSSOM?
> 
> I tried but I couldn't find a way to retrieve the actual font name.
> (I can get 'myfont' but not 'Arial' in the above example).

What I meant was to test the value of documents.styleSheets[0].rules[0].style.unicodeRange, but it looks like there’s insufficient support for unicodeRange values in WebKit’s CSSOM implementation.

[Yuzo Fujishima]

Committed r62161: <http://trac.webkit.org/changeset/62161>