Bug 41326

Summary: Refactor common code into addChildCommon
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, darin, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 41331    
Bug Blocks:    
Attachments:
Description Flags
Patch for landing
none
Patch for landing abarth: commit-queue+

Adam Barth
Reported 2010-06-28 19:08:38 PDT
Refactor common code into addChildCommon
Attachments
Patch for landing (3.98 KB, patch)
2010-06-28 19:09 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.98 KB, patch)
2010-06-28 21:10 PDT, Adam Barth 		abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-28 19:09:29 PDT
Created attachment 59976 [details] Patch for landing
WebKit Commit Bot
Comment 2 2010-06-28 20:45:14 PDT
Comment on attachment 59976 [details] Patch for landing Rejecting patch 59976 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/dom/ContainerNode.cpp Hunk #2 FAILED at 550. 1 out of 3 hunks FAILED -- saving rejects to file WebCore/dom/ContainerNode.cpp.rej patching file WebCore/dom/ContainerNode.h patching file WebCore/dom/Node.h Hunk #1 FAILED at 265. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/dom/Node.h.rej Full output: http://webkit-commit-queue.appspot.com/results/3328917
Adam Barth
Comment 3 2010-06-28 21:10:28 PDT
Created attachment 59980 [details] Patch for landing
Adam Barth
Comment 4 2010-06-28 21:37:58 PDT
Committed r62084: <http://trac.webkit.org/changeset/62084>
WebKit Review Bot
Comment 5 2010-06-28 21:52:52 PDT
http://trac.webkit.org/changeset/62084 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62083 http://trac.webkit.org/changeset/62084
Darin Adler
Comment 6 2010-06-29 10:25:32 PDT
Seems parserAddChild should be inlined.
Adam Barth
Comment 7 2010-06-29 10:33:58 PDT
> Seems parserAddChild should be inlined. Yep. Or addChildCommon could be inlined.
Note You need to log in before you can comment on or make changes to this bug.