| Summary: | Refactor common code into addChildCommon | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, commit-queue, darin, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | 41331 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2010-06-28 19:08:38 PDT
Created attachment 59976 [details]
Patch for landing
Comment on attachment 59976 [details] Patch for landing Rejecting patch 59976 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/dom/ContainerNode.cpp Hunk #2 FAILED at 550. 1 out of 3 hunks FAILED -- saving rejects to file WebCore/dom/ContainerNode.cpp.rej patching file WebCore/dom/ContainerNode.h patching file WebCore/dom/Node.h Hunk #1 FAILED at 265. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/dom/Node.h.rej Full output: http://webkit-commit-queue.appspot.com/results/3328917 Created attachment 59980 [details]
Patch for landing
Committed r62084: <http://trac.webkit.org/changeset/62084> http://trac.webkit.org/changeset/62084 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62083 http://trac.webkit.org/changeset/62084 Seems parserAddChild should be inlined. > Seems parserAddChild should be inlined.
Yep. Or addChildCommon could be inlined.
|