Summary: | Cairo: Need to implement GraphicsContext::clipConvexPolygon() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, krit, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 41732 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Beth Dakin
2010-06-28 15:02:08 PDT
Created attachment 62910 [details]
Add support for clipConvexPolygon and enable path based borders
Great patch. Just one question, you change fillRule and antialiasing settings of the context in clipConvexPolygon, should they be restored to the previos settings, or is this not neccessary? You're right. I was doing that, but at some point that change was lost. I've re-added it. Thanks! Created attachment 62987 [details]
Patch which preserves antialias and fill rules
Comment on attachment 62987 [details]
Patch which preserves antialias and fill rules
LGTM. r=me. Well done! :-) These were the first pixel results I reviewed for the Cairo ports.
Committed r64338: <http://trac.webkit.org/changeset/64338> |