Bug 41299

Summary: Build up WebKitTestRunner output in the InjectedBundle
Product: WebKit Reporter: Sam Weinig <sam>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch andersca: review+

Sam Weinig
Reported 2010-06-28 13:17:37 PDT
We should build up WebKitTestRunner output in the InjectedBundle to simplify code and allow for easier implementation of the other types of dumping.
Attachments
patch (14.28 KB, patch)
2010-06-28 13:19 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-06-28 13:19:17 PDT
Created attachment 59929 [details] patch
WebKit Review Bot
Comment 2 2010-06-28 13:20:42 PDT
Attachment 59929 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/WebKitTestRunner/TestInvocation.h:51: _didRecieveMessageFromInjectedBundle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.h:35: Alphabetical sorting problem. [build/include_order] [4] WebKitTools/WebKitTestRunner/TestInvocation.cpp:123: TestInvocation::_didRecieveMessageFromInjectedBundle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-06-28 13:21:09 PDT
Comment on attachment 59929 [details] patch r=me
Sam Weinig
Comment 4 2010-06-28 13:26:35 PDT
Landed in r62032.
WebKit Review Bot
Comment 5 2010-06-28 14:23:59 PDT
http://trac.webkit.org/changeset/62032 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/62032 http://trac.webkit.org/changeset/62033 http://trac.webkit.org/changeset/62034 http://trac.webkit.org/changeset/62031
Note You need to log in before you can comment on or make changes to this bug.