Bug 41286 – [chromium] EditorClient should forward text field related calls to the WebViewClient

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Jay Civelli]

In order to be able to move password autocomplete and field autocomplete code from EditorClientImpl.cpp to the Chromium code, the text field related methods should be exposed on the WebViewClient.

[Jay Civelli]

Created attachment 59930 [details]
First version of the patch

[Dirk Pranke]

Comment on attachment 59930 [details]
First version of the patch

Looks basically good to me, but I'm neither an expert on this area of the code nor a reviewer :)

[Darin Fisher (:fishd, Google)]

Comment on attachment 59930 [details]
First version of the patch

WebKit/chromium/src/EditorClientImpl.cpp:823
 +      HTMLInputElement* inputElement = WebKit::toHTMLInputElement(element);
EditorClientImpl is defined in the WebKit namespace, so you don't
need to have the WebKit:: prefix before toHTMLInputElement.

WebKit/chromium/public/WebViewClient.h:146
 +      virtual void textFieldHandlingKeyDown(const WebInputElement&, const WebKeyboardEvent&) { }
textFieldDidReceiveKeyDown?

WebKit/chromium/public/WebViewClient.h:144
 +      virtual void textDidChangeInTextField(const WebInputElement&) { }
textFieldDidChange?

WebKit/chromium/public/WebInputElement.h:83
 +          WEBKIT_API bool readOnly() const;
hmm... maybe this should be named isReadOnly to match isEnabledFormControl.
i know you are just replicating readOnly from the WebCore name.

looks good otherwise.

[Jay Civelli]

Created attachment 60411 [details]
Updated with fishd's suggested changes

[Darin Fisher (:fishd, Google)]

Comment on attachment 60411 [details]
Updated with fishd's suggested changes

WebKit/chromium/public/WebViewClient.h:142
 +      // Called when a key down happens in a text-field.
this comment seems fairly redundant now with the method name, so you could
leave it out.

R=me

[Jay Civelli]

Created attachment 60808 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 60808 [details]
Patch for landing

Rejecting patch 60808 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 60808 [details]
Patch for landing

Clearing flags on attachment: 60808

Committed r62893: <http://trac.webkit.org/changeset/62893>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.