Bug 41283

Summary: [chromium] password autocomplete and field autocomplete should be moved out of EditorClientImpl.cpp
Product: WebKit Reporter: Jay Civelli <jcivelli>
Component: WebKit Misc.Assignee: Jay Civelli <jcivelli>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, dpranke, fishd, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 48217    
Bug Blocks:    
Attachments:
Description Flags
Turning on the Chromium autocomplete implementation.
none
Removed name in FIXME
none
Patch
none
Patch for landing levin: review+, levin: commit-queue+

Description Jay Civelli 2010-06-28 10:05:41 PDT 
The code for password autocompletion and form field autocomplete is currently in EditClientImpl.cpp
It should be moved to the Chromium code.
The motivation is to keep the logic out of the Chromium WebKit API.
Comment 1 Jay Civelli 2010-10-18 15:48:31 PDT 
Created attachment 71096 [details]
Turning on the Chromium autocomplete implementation.
Comment 2 David Levin 2010-10-19 15:54:25 PDT 
fyi, FIXME in WebKit shouldn't contain names.
Comment 3 Jay Civelli 2010-10-21 10:06:58 PDT 
Created attachment 71450 [details]
Removed name in FIXME
Comment 4 WebKit Commit Bot 2010-10-22 16:06:49 PDT 
Comment on attachment 71450 [details]
Removed name in FIXME

Clearing flags on attachment: 71450

Committed r70361: <http://trac.webkit.org/changeset/70361>
Comment 5 WebKit Commit Bot 2010-10-22 16:06:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Jay Civelli 2010-10-27 23:58:46 PDT 
Created attachment 72149 [details]
Patch
Comment 7 Jay Civelli 2010-10-28 00:00:40 PDT 
Created attachment 72150 [details]
Patch for landing