Bug 41283

Summary: [chromium] password autocomplete and field autocomplete should be moved out of EditorClientImpl.cpp
Product: WebKit Reporter: Jay Civelli <jcivelli>
Component: WebKit Misc.Assignee: Jay Civelli <jcivelli>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, dpranke, fishd, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 48217    
Bug Blocks:    
Attachments:
Description Flags
Turning on the Chromium autocomplete implementation.
none
Removed name in FIXME
none
Patch
none
Patch for landing levin: review+, levin: commit-queue+

Jay Civelli
Reported 2010-06-28 10:05:41 PDT
The code for password autocompletion and form field autocomplete is currently in EditClientImpl.cpp It should be moved to the Chromium code. The motivation is to keep the logic out of the Chromium WebKit API.
Attachments
Turning on the Chromium autocomplete implementation. (1.07 KB, patch)
2010-10-18 15:48 PDT, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Removed name in FIXME (1.04 KB, patch)
2010-10-21 10:06 PDT, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2010-10-27 23:58 PDT, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.14 KB, patch)
2010-10-28 00:00 PDT, Jay Civelli 		levin: review+
levin: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jay Civelli
Comment 1 2010-10-18 15:48:31 PDT
Created attachment 71096 [details] Turning on the Chromium autocomplete implementation.
David Levin
Comment 2 2010-10-19 15:54:25 PDT
fyi, FIXME in WebKit shouldn't contain names.
Jay Civelli
Comment 3 2010-10-21 10:06:58 PDT
Created attachment 71450 [details] Removed name in FIXME
WebKit Commit Bot
Comment 4 2010-10-22 16:06:49 PDT
Comment on attachment 71450 [details] Removed name in FIXME Clearing flags on attachment: 71450 Committed r70361: <http://trac.webkit.org/changeset/70361>
WebKit Commit Bot
Comment 5 2010-10-22 16:06:55 PDT
All reviewed patches have been landed. Closing bug.
Jay Civelli
Comment 6 2010-10-27 23:58:46 PDT
Created attachment 72149 [details] Patch
Jay Civelli
Comment 7 2010-10-28 00:00:40 PDT
Created attachment 72150 [details] Patch for landing
Note You need to log in before you can comment on or make changes to this bug.