Bug 41243

Summary:

[chromium] Add support for WebGL to the accelerated compositor

Product:

WebKit

Reporter:

Vangelis Kokkevis <vangelis>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, fishd, kbr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	fishd: review-
Proposed patch. Fixed linux compile issue.	fishd: review+, fishd: commit-queue+

Vangelis Kokkevis

Reported 2010-06-25 19:19:30 PDT

Currently Canvas3D (WebGL) isn't supported in chromium when doing accelerated compositing.

Attachments
Proposed patch (20.66 KB, patch) 2010-06-26 10:59 PDT, Vangelis Kokkevis	fishd: review-	Details Formatted Diff Diff
Proposed patch. Fixed linux compile issue. (20.69 KB, patch) 2010-06-28 15:19 PDT, Vangelis Kokkevis	fishd: review+ fishd: commit-queue+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Vangelis Kokkevis

Comment 1 2010-06-26 10:59:23 PDT

Created attachment 59841 [details] Proposed patch This code requires: http://codereview.chromium.org/2864021/show to be landed in the chromium repository first.

WebKit Review Bot

Comment 2 2010-06-26 11:50:04 PDT

Attachment 59841 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3297828

Darin Fisher (:fishd, Google)

Comment 3 2010-06-28 08:53:51 PDT

Comment on attachment 59841 [details] Proposed patch WebKit/chromium/public/WebGraphicsContext3D.h:116 + virtual unsigned int getPlatformTextureId() = 0; nit: "unsigned int" -> "unsigned" in webkit style WebKit/chromium/src/GraphicsContext3D.cpp:363 + if (!webContext->initialize(webAttributes, webView)) { instead of initializing a WebGraphicsContext3D with a WebView, we should instead ask the WebViewClient to create a WebGraphicsContext3D for us. things that you request from a WebKitClient should not be WebView or WebFrame dependent. looks fine otherwise.

Vangelis Kokkevis

Comment 4 2010-06-28 15:19:33 PDT

Created attachment 59951 [details] Proposed patch. Fixed linux compile issue.

Vangelis Kokkevis

Comment 5 2010-06-28 15:25:22 PDT

(In reply to comment #3) > (From update of attachment 59841 [details]) > WebKit/chromium/public/WebGraphicsContext3D.h:116 > + virtual unsigned int getPlatformTextureId() = 0; > nit: "unsigned int" -> "unsigned" in webkit style Done. > > WebKit/chromium/src/GraphicsContext3D.cpp:363 > + if (!webContext->initialize(webAttributes, webView)) { > instead of initializing a WebGraphicsContext3D with a WebView, we > should instead ask the WebViewClient to create a WebGraphicsContext3D > for us. things that you request from a WebKitClient should not be > WebView or WebFrame dependent. If it's ok, I'd like to make this change in a separate CL. I've filed a bug for it: https://bugs.webkit.org/show_bug.cgi?id=41315 > > looks fine otherwise.

Kenneth Russell

Comment 6 2010-06-28 17:16:26 PDT

Comment on attachment 59951 [details] Proposed patch. Fixed linux compile issue. Looks good. Very exciting.

Darin Fisher (:fishd, Google)

Comment 7 2010-06-29 10:12:52 PDT

Landed as http://trac.webkit.org/changeset/62130

Note You need to log in before you can comment on or make changes to this bug.