Bug 41223

Summary:

[chromium] Send unhandled events to Node's default handler

Product:

WebKit

Reporter:

John Abd-El-Malek <jam>

Component:

New Bugs

Assignee:

John Abd-El-Malek <jam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	levin: review+

John Abd-El-Malek

Reported 2010-06-25 12:34:08 PDT

[chromium] Send unhandled events to Node's default handler

Attachments
Patch (1.37 KB, patch) 2010-06-25 12:38 PDT, John Abd-El-Malek	no flags	Details Formatted Diff Diff
Patch (1.37 KB, patch) 2010-06-25 14:29 PDT, John Abd-El-Malek	levin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

John Abd-El-Malek

Comment 1 2010-06-25 12:38:21 PDT

Created attachment 59788 [details] Patch

Darin Fisher (:fishd, Google)

Comment 2 2010-06-25 13:45:13 PDT

Comment on attachment 59788 [details] Patch WebKit/chromium/src/WebPluginContainerImpl.cpp:171 > + // FIXME: it would be cleaner if widge::handleEvent returned true/false and nit: "widge" -> Widget WebKit/chromium/src/WebPluginContainerImpl.cpp:174 + m_element->Node::defaultEventHandler(event); nit: indent by 4 spaces

John Abd-El-Malek

Comment 3 2010-06-25 14:27:46 PDT

fixed

John Abd-El-Malek

Comment 4 2010-06-25 14:29:43 PDT

Created attachment 59797 [details] Patch

John Abd-El-Malek

Comment 5 2010-06-25 17:20:19 PDT

Committed r61919: <http://trac.webkit.org/changeset/61919>

Note You need to log in before you can comment on or make changes to this bug.