Bug 41223

Summary:

[chromium] Send unhandled events to Node's default handler

Product:

WebKit

Reporter:

John Abd-El-Malek <jam>

Component:

New Bugs

Assignee:

John Abd-El-Malek <jam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	levin: review+

Description John Abd-El-Malek 2010-06-25 12:34:08 PDT

[chromium] Send unhandled events to Node's default handler

Comment 1 John Abd-El-Malek 2010-06-25 12:38:21 PDT

Created attachment 59788 [details]
Patch

Comment 2 Darin Fisher (:fishd, Google) 2010-06-25 13:45:13 PDT

Comment on attachment 59788 [details]
Patch

WebKit/chromium/src/WebPluginContainerImpl.cpp:171
> +      // FIXME: it would be cleaner if widge::handleEvent returned true/false and
nit: "widge" -> Widget

WebKit/chromium/src/WebPluginContainerImpl.cpp:174
 +        m_element->Node::defaultEventHandler(event);
nit: indent by 4 spaces

Comment 3 John Abd-El-Malek 2010-06-25 14:27:46 PDT

fixed

Comment 4 John Abd-El-Malek 2010-06-25 14:29:43 PDT

Created attachment 59797 [details]
Patch

Comment 5 John Abd-El-Malek 2010-06-25 17:20:19 PDT

Committed r61919: <http://trac.webkit.org/changeset/61919>