Bug 41215

Summary:

JIT property access should mark internal references to GC'd objects

Product:

WebKit

Reporter:

Nathan Lawrence <nlawrence>

Component:

JavaScriptCore

Assignee:

Nathan Lawrence <nlawrence>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

barraclough, commit-queue, eric, fpizlo, ggaren, gustavo, nlawrence, slewis, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch (now with asserts!)	none
Patch	oliver: review-
Patch	none
Patch	oliver: review-
Patch (minus ChangeLog cruft)	none
patch (up to date)	oliver: review-
patch	none
patch	none
patch (up to date)	none
patch	ggaren: review-
patch (with vcproj)	none
patch	none

Nathan Lawrence

Reported 2010-06-25 08:59:45 PDT

Created attachment 59771 [details] Patch The JIT code contains a number of direct references to GC'd objects. When we have movable objects, these references will need to be updated.

Attachments
Patch (16.98 KB, patch) 2010-06-25 08:59 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
Patch (17.75 KB, patch) 2010-06-25 09:53 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
Patch (now with asserts!) (43.15 KB, patch) 2010-06-30 13:49 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
Patch (37.74 KB, patch) 2010-06-30 14:09 PDT, Nathan Lawrence	oliver: review-	Details Formatted Diff Diff
Patch (51.26 KB, patch) 2010-07-29 09:28 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
Patch (51.26 KB, patch) 2010-07-29 09:40 PDT, Nathan Lawrence	oliver: review-	Details Formatted Diff Diff
Patch (minus ChangeLog cruft) (50.85 KB, patch) 2010-08-02 10:52 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
patch (up to date) (53.08 KB, patch) 2010-08-04 16:19 PDT, Nathan Lawrence	oliver: review-	Details Formatted Diff Diff
patch (52.55 KB, patch) 2010-08-05 15:12 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
patch (52.50 KB, patch) 2010-08-05 15:17 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
patch (up to date) (52.48 KB, patch) 2010-08-05 16:10 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
patch (52.92 KB, patch) 2010-08-05 16:54 PDT, Nathan Lawrence	ggaren: review-	Details Formatted Diff Diff
patch (with vcproj) (52.92 KB, patch) 2010-08-06 13:32 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
patch (56.35 KB, patch) 2010-08-06 14:49 PDT, Nathan Lawrence	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2010-06-25 09:01:42 PDT

Attachment 59771 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/bytecode/StructureStubInfo.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] JavaScriptCore/bytecode/Instruction.h:84: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 5 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 2 2010-06-25 09:07:08 PDT

Attachment 59771 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3276777

WebKit Review Bot

Comment 3 2010-06-25 09:30:04 PDT

Attachment 59771 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3303756

Nathan Lawrence

Comment 4 2010-06-25 09:53:40 PDT

Created attachment 59775 [details] Patch This should fix the compilation problems on 32 bit.

WebKit Review Bot

Comment 5 2010-06-25 09:54:30 PDT

Attachment 59775 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/bytecode/StructureStubInfo.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] JavaScriptCore/bytecode/Instruction.h:84: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 5 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Nathan Lawrence

Comment 6 2010-06-30 13:49:40 PDT

Created attachment 60146 [details] Patch (now with asserts!) Per Gavin's suggestion, there are now ASSERT_JIT_OFFSETS for the constants used in patching the generated code. Currently the constants only exist for X86_64 with JSValue64 and X86 with JSValue32_64.

Nathan Lawrence

Comment 7 2010-06-30 14:09:52 PDT

Created attachment 60149 [details] Patch

WebKit Review Bot

Comment 8 2010-06-30 14:11:24 PDT

Attachment 60149 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/bytecode/StructureStubInfo.h:38: Code inside a namespace should not be indented. [whitespace/indent] [4] JavaScriptCore/jit/JITMarkObjects.cpp:40: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/bytecode/Instruction.h:84: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:84: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 6 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 9 2010-07-04 20:26:49 PDT

Comment on attachment 60149 [details] Patch The various count members should only be included in builds that have ENABLE(MOVABLE_GC_OBJECTS), otherwise it increases the size of the struct.

Nathan Lawrence

Comment 10 2010-07-29 09:28:32 PDT

Created attachment 62958 [details] Patch Adds preprocessor conditionals around more added code + also marks the loads into the prototype object.

WebKit Review Bot

Comment 11 2010-07-29 09:29:24 PDT

Attachment 62958 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/JITMarkObjects.cpp:35: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/jit/JITMarkObjects.cpp:65: Missing space before ( in switch( [whitespace/parens] [5] JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 11 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Nathan Lawrence

Comment 12 2010-07-29 09:40:49 PDT

Created attachment 62963 [details] Patch should be #define ENABLE_MOVABLE_GC_OBJECTS 0

WebKit Review Bot

Comment 13 2010-07-29 09:45:12 PDT

Attachment 62963 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/JITMarkObjects.cpp:35: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/jit/JITMarkObjects.cpp:65: Missing space before ( in switch( [whitespace/parens] [5] JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 11 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 14 2010-07-29 12:55:53 PDT

Comment on attachment 62963 [details] Patch r=me, but there's some cruft in the changelog that you should remove

Nathan Lawrence

Comment 15 2010-08-02 10:52:10 PDT

Created attachment 63236 [details] Patch (minus ChangeLog cruft)

WebKit Review Bot

Comment 16 2010-08-02 10:55:07 PDT

Attachment 63236 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/JITPropertyAccess.cpp:577: One line control clauses should not use braces. [whitespace/braces] [4] JavaScriptCore/jit/JITMarkObjects.cpp:35: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/jit/JITMarkObjects.cpp:66: Missing space before ( in switch( [whitespace/parens] [5] JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 12 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 17 2010-08-02 20:03:35 PDT

Attachment 63236 [details] did not build on win: Build output: http://queues.webkit.org/results/3578831

Oliver Hunt

Comment 18 2010-08-03 10:25:28 PDT

Comment on attachment 63236 [details] Patch (minus ChangeLog cruft) r=me

WebKit Commit Bot

Comment 19 2010-08-04 08:46:23 PDT

Comment on attachment 63236 [details] Patch (minus ChangeLog cruft) Rejecting patch 63236 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Oliver Hunt', u'--force']" exit_code: 1 Last 500 characters of output: ed at 1071 (offset 28 lines). Hunk #11 succeeded at 1089 (offset 30 lines). Hunk #12 FAILED at 1110. 4 out of 12 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITPropertyAccess.cpp.rej patching file JavaScriptCore/jit/JITStubs.cpp Hunk #1 FAILED at 934. Hunk #2 FAILED at 954. Hunk #3 FAILED at 1569. 3 out of 3 hunks FAILED -- saving rejects to file JavaScriptCore/jit/JITStubs.cpp.rej patching file JavaScriptCore/wtf/Platform.h Hunk #1 succeeded at 1073 with fuzz 2 (offset 12 lines). Full output: http://queues.webkit.org/results/3642303

Nathan Lawrence

Comment 20 2010-08-04 16:19:53 PDT

Created attachment 63508 [details] patch (up to date)

WebKit Review Bot

Comment 21 2010-08-04 16:25:00 PDT

Attachment 63508 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/JITPropertyAccess.cpp:580: One line control clauses should not use braces. [whitespace/braces] [4] JavaScriptCore/jit/JITMarkObjects.cpp:35: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/jit/JITMarkObjects.cpp:66: Missing space before ( in switch( [whitespace/parens] [5] JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 12 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 22 2010-08-05 03:31:34 PDT

Attachment 63508 [details] did not build on win: Build output: http://queues.webkit.org/results/3601744

Eric Seidel (no email)

Comment 23 2010-08-05 08:54:35 PDT

Comment on attachment 63236 [details] Patch (minus ChangeLog cruft) Cleared Oliver Hunt's review+ from obsolete attachment 63236 [details] so that this bug does not appear in http://webkit.org/pending-commit.

Oliver Hunt

Comment 24 2010-08-05 14:30:03 PDT

Comment on attachment 63508 [details] patch (up to date) This basically looks fine, but you should remove the change from platform.h that turns the movable logic on.

Nathan Lawrence

Comment 25 2010-08-05 15:12:23 PDT

Created attachment 63642 [details] patch

WebKit Review Bot

Comment 26 2010-08-05 15:13:40 PDT

Attachment 63642 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/jit/JITPropertyAccess.cpp:580: One line control clauses should not use braces. [whitespace/braces] [4] JavaScriptCore/jit/JITMarkObjects.cpp:35: Alphabetical sorting problem. [build/include_order] [4] JavaScriptCore/jit/JITMarkObjects.cpp:66: Missing space before ( in switch( [whitespace/parens] [5] JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 12 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Nathan Lawrence

Comment 27 2010-08-05 15:17:57 PDT

Created attachment 63643 [details] patch fixed some of the style issues

WebKit Review Bot

Comment 28 2010-08-05 15:20:38 PDT

Attachment 63643 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 9 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Nathan Lawrence

Comment 29 2010-08-05 16:10:12 PDT

Created attachment 63655 [details] patch (up to date)

WebKit Review Bot

Comment 30 2010-08-05 16:10:53 PDT

Attachment 63655 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 9 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 31 2010-08-05 16:33:12 PDT

Attachment 63655 [details] did not build on qt: Build output: http://queues.webkit.org/results/3595889

Nathan Lawrence

Comment 32 2010-08-05 16:54:01 PDT

Created attachment 63662 [details] patch This should fix the QT build errors.

WebKit Review Bot

Comment 33 2010-08-05 16:56:18 PDT

Attachment 63662 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 9 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 34 2010-08-05 21:58:12 PDT

Attachment 63662 [details] did not build on win: Build output: http://queues.webkit.org/results/3626497

Nathan Lawrence

Comment 35 2010-08-06 13:32:28 PDT

Created attachment 63754 [details] patch (with vcproj)

Geoffrey Garen

Comment 36 2010-08-06 14:09:45 PDT

Comment on attachment 63662 [details] patch I think this is the kind of patch that would benefit from some line-by-line explanation in the ChangeLog. + compileGetDirectOffset(protoObject, regT1, regT1, regT2, cachedOffset); + move(regT2, regT0); I think it's layering violation to require the JIT to know which temporary registers to use, because some temporaries on some platforms change the size of the instruction. That's very subtle, and likely to go wrong in the future. I'd prefer having compileGetDirectOffset use a MacroAssembler API that guarantees a constant size for its instructions.

Nathan Lawrence

Comment 37 2010-08-06 14:49:00 PDT

Created attachment 63764 [details] patch

WebKit Review Bot

Comment 38 2010-08-06 14:50:52 PDT

Attachment 63764 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/bytecode/Instruction.h:80: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _proto is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:80: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _stubRoutine is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _base is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _chain is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _count is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/bytecode/Instruction.h:95: _propertyType is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 9 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 39 2010-08-06 15:51:10 PDT

Comment on attachment 63764 [details] patch r=me

Eric Seidel (no email)

Comment 40 2010-08-07 23:05:08 PDT

Comment on attachment 63764 [details] patch Clearing flags on attachment: 63764 Committed r64938: <http://trac.webkit.org/changeset/64938>

Eric Seidel (no email)

Comment 41 2010-08-07 23:05:17 PDT

All reviewed patches have been landed. Closing bug.

Geoffrey Garen

Comment 42 2010-08-08 19:27:54 PDT

Rolled out in bug 43685.

Filip Pizlo

Comment 43 2015-07-02 15:48:30 PDT

This isn't necessary anymore. We have a twofold story for this: 1) The GC can pin objects. 2) The JITs tell the GC what objects the JIT code references, and in what manner (strong, weak, ephemeral).

Filip Pizlo

Comment 44 2015-07-02 15:49:02 PDT

Meant to be resolved/invalid.

Note You need to log in before you can comment on or make changes to this bug.