Bug 41205

Summary: REGRESSION(r61833): It broke Leopard and GTK (Requested by Ossy_ on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, ggaren, ossy, rhodovan.u-szeged, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41055    
Attachments:
Description Flags
ROLLOUT of r61833 none

Description WebKit Review Bot 2010-06-25 03:03:21 PDT 
http://trac.webkit.org/changeset/61833 broke the build:
It broke Leopard and GTK (Requested by Ossy_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-06-25 03:03:35 PDT 
Created attachment 59752 [details]
ROLLOUT of r61833

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Csaba Osztrogonác 2010-06-25 03:09:50 PDT 
It broke Leopard Debug: http://build.webkit.org/results/Leopard%20Intel%20Debug%20%28Tests%29/r61833%20%2816354%29/results.html

and broke GTK: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r61833%20%287203%29/results.html

ASSERTION FAILED: m_table
(../../JavaScriptCore/wtf/HashTable.h:193 void WTF::HashTableConstIterator<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::checkValidity() const [with Key = JSC::RegExpKey, Value = std::pair<JSC::RegExpKey, WTF::RefPtr<JSC::RegExp> >, Extractor = WTF::PairFirstExtractor<std::pair<JSC::RegExpKey, WTF::RefPtr<JSC::RegExp> > >, HashFunctions = WTF::RegExpHash<JSC::RegExpKey>, Traits = WTF::PairHashTraits<WTF::HashTraits<JSC::RegExpKey>, WTF::HashTraits<WTF::RefPtr<JSC::RegExp> > >, KeyTraits = WTF::HashTraits<JSC::RegExpKey>])
Comment 3 WebKit Commit Bot 2010-06-25 03:17:05 PDT 
Comment on attachment 59752 [details]
ROLLOUT of r61833

Clearing flags on attachment: 59752

Committed r61845: <http://trac.webkit.org/changeset/61845>
Comment 4 WebKit Commit Bot 2010-06-25 03:17:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-06-25 04:00:01 PDT 
http://trac.webkit.org/changeset/61845 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/61843
http://trac.webkit.org/changeset/61844
http://trac.webkit.org/changeset/61845
Comment 6 Csaba Osztrogonác 2010-06-25 04:01:07 PDT 
(In reply to comment #5)
> http://trac.webkit.org/changeset/61845 might have broken GTK Linux 64-bit Debug
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/61843
> http://trac.webkit.org/changeset/61844
> http://trac.webkit.org/changeset/61845

Rollout doesn't brake bots.