|Summary:||[QT][S60] build-webkit scripts picks wrong make spec for windows build|
|Product:||WebKit||Reporter:||Mahesh Kulkarni <maheshk>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||commit-queue, hausmann, laszlo.gombos|
|Version:||528+ (Nightly build)|
Description Mahesh Kulkarni 2010-06-25 01:03:18 PDT
While building webkit with "build-webkit --qt" for windows port, symbian makespec is picked by scripts. Env variable %EPOCROOT% existence is treated as symbian builds resulting in only either of build to work (windows or symbian port)
Comment 1 Mahesh Kulkarni 2010-06-25 01:11:49 PDT
Created attachment 59741 [details] remove EPOCROOT check Do not check for existence of %EPOCROOT% in determineIsSymbian(). As fails to build windows port of QtWebkit on same machine which has symbian env setup. To build for symbian, we have 1) use "build-webkit --qt --symbian" 2) \epoc32\tools comes before windows QTDIR setup in %PATH%
Comment 2 Laszlo Gombos 2010-06-25 07:56:52 PDT
This makes sense to me so I support this change. I think for Symbian builds most people use the "--symbian" option already. %EPOCROOT% could be set for various reasons (e.g. one installed the Symbian SDK) which does not necessary implies that one is looking for a Symbian build. I think the other valid point is that there is no way to force a windows build if %EPOCROOT% is set - yes this can be easily worked around. Simon, what do you think (as the original author if this code) ?
Comment 3 Simon Hausmann 2010-06-26 14:11:44 PDT
Comment on attachment 59741 [details] remove EPOCROOT check Looks good to me.
Comment 4 Mahesh Kulkarni 2010-06-27 21:32:03 PDT
Comment on attachment 59741 [details] remove EPOCROOT check Raising check-in request
Comment 5 Simon Hausmann 2010-06-28 04:19:11 PDT
Comment on attachment 59741 [details] remove EPOCROOT check Please set cq+ at patch upload time.
Comment 6 WebKit Commit Bot 2010-06-28 04:34:23 PDT
Comment on attachment 59741 [details] remove EPOCROOT check Rejecting patch 59741 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Simon Hausmann', u'--force']" exit_code: 1 Last 500 characters of output: g Hunk #1 succeeded at 1 with fuzz 3. (Stripping trailing CRs from patch.) can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: Scripts/webkitdirs.pm |=================================================================== |--- Scripts/webkitdirs.pm (revision 61528) |+++ Scripts/webkitdirs.pm (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Full output: http://webkit-commit-queue.appspot.com/results/3279869
Comment 7 Simon Hausmann 2010-06-28 05:22:06 PDT
Committed r61995: <http://trac.webkit.org/changeset/61995>
Comment 8 Simon Hausmann 2010-06-29 01:05:32 PDT
Revision r61995 cherry-picked into qtwebkit-2.0 with commit 85e7e360c2cb0653f8c6885e0f5d06743e077d11