| Summary: | Fix testapi.c to account for movable objects | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nathan Lawrence <nlawrence> | ||||||
| Component: | JavaScriptCore | Assignee: | Nathan Lawrence <nlawrence> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ggaren, nlawrence, oliver, slewis | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 59701 [details]
Patch
r=me
Comment on attachment 59701 [details]
Patch
aStackRef should be cleared immediately after JSObjectSetPrivateProperty as the private storage should then keep the heap reference live.
Basically because aHeapRef needs to be pinned somehow -- realistically we'll need some kind of layer for API objects to GC allocate handles i guess :-/ Created attachment 59784 [details]
Patch
Updated per Oliver's comment. (In reply to comment #3) > Basically because aHeapRef needs to be pinned somehow -- realistically we'll need some kind of layer for API objects to GC allocate handles i guess :-/ The current plan is just not to move objects pointed to by the stack. Comment on attachment 59784 [details]
Patch
r=me
Comment on attachment 59784 [details] Patch Clearing flags on attachment: 59784 Committed r61946: <http://trac.webkit.org/changeset/61946> All reviewed patches have been landed. Closing bug. |
Created attachment 59701 [details] Patch We assume in testapi.c that the value aHeapRef refers to will not be moved. When we have movable objects, this will not be the case.