Bug 41176

Summary: Fix testapi.c to account for movable objects
Product: WebKit Reporter: Nathan Lawrence <nlawrence>
Component: JavaScriptCoreAssignee: Nathan Lawrence <nlawrence>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, nlawrence, oliver, slewis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
ggaren: review+, ggaren: commit-queue+
Patch none

Nathan Lawrence
Reported 2010-06-24 14:22:02 PDT
Created attachment 59701 [details] Patch We assume in testapi.c that the value aHeapRef refers to will not be moved. When we have movable objects, this will not be the case.
Attachments
Patch (1.96 KB, patch)
2010-06-24 14:22 PDT, Nathan Lawrence 		ggaren: review+
ggaren: commit-queue+
DetailsFormatted DiffDiff
Patch (2.14 KB, patch)
2010-06-25 11:45 PDT, Nathan Lawrence 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2010-06-24 15:53:29 PDT
Comment on attachment 59701 [details] Patch r=me
Oliver Hunt
Comment 2 2010-06-24 23:45:49 PDT
Comment on attachment 59701 [details] Patch aStackRef should be cleared immediately after JSObjectSetPrivateProperty as the private storage should then keep the heap reference live.
Oliver Hunt
Comment 3 2010-06-24 23:48:06 PDT
Basically because aHeapRef needs to be pinned somehow -- realistically we'll need some kind of layer for API objects to GC allocate handles i guess :-/
Nathan Lawrence
Comment 4 2010-06-25 11:45:12 PDT
Created attachment 59784 [details] Patch
Nathan Lawrence
Comment 5 2010-06-25 11:46:09 PDT
Updated per Oliver's comment.
Geoffrey Garen
Comment 6 2010-06-25 11:54:13 PDT
(In reply to comment #3) > Basically because aHeapRef needs to be pinned somehow -- realistically we'll need some kind of layer for API objects to GC allocate handles i guess :-/ The current plan is just not to move objects pointed to by the stack.
Geoffrey Garen
Comment 7 2010-06-25 16:54:26 PDT
Comment on attachment 59784 [details] Patch r=me
WebKit Commit Bot
Comment 8 2010-06-25 23:25:58 PDT
Comment on attachment 59784 [details] Patch Clearing flags on attachment: 59784 Committed r61946: <http://trac.webkit.org/changeset/61946>
WebKit Commit Bot
Comment 9 2010-06-25 23:26:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.