Bug 41156 – Cross origin XMLHttpRequest should log the reason why connection failed

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Stuart Ng]

Created attachment 59652 [details]
Actual Packet Capture - Can open with Microsoft Network Monitor or WireShark

Send a Cross Origin XHR Post method, and call send with actual data (Tried String and ByteArray)
Get a XHR Status of 0, and eventually get XML Network Error DOM 101.

Cross Origin POST with no data works fine. GET, HEAD Cross Origin also works.

I have reproduced this on Chrome and Safari.

From the packet capture I see HTTP Option being sent with requested method of POST
And we get a response back with Accept-Method of POST as well, but nothing else afterwards

NOte: For POST with no data you never see the Preflight request being sent

[Alexey Proskuryakov]

> Access-Control-Request-Headers: X-Requested-With, Content-Type
< Access-Control-Allow-Headers: X-Requested-With

Is this perhaps the problem?

[Stuart Ng]

Yes this is it! The bug can be closed.

I added "Content-Type to allow-header" and things work.

[Alexey Proskuryakov]

Let's track this as a developer tools issue then. It's really hard to figure out problems like this with WebKit.

[Alexey Proskuryakov]

*** Bug 41217 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

Created attachment 60425 [details]
first iteration

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/62576>. This actually affected a number of tests!

[Alexey Proskuryakov]

+        if (!m_headers.contains(it->first) && !isOnAccessControlSimpleRequestHeaderWhitelist(it->first, it->second)) {
+            errorDescription = "Request header field " + it->first + " is not allowed by Access-Control-Allow-Methods response header field.";

Oops, that's "Access-Control-Allow-Headers". Corrected in r62592.

[WebKit Review Bot]

http://trac.webkit.org/changeset/62576 might have broken Leopard Intel Debug (Tests)

[Adam Barth]

(In reply to comment #8)
> http://trac.webkit.org/changeset/62576 might have broken Leopard Intel Debug (Tests)

11 hours later and the tree is still busted from this change.

[Adam Barth]

I attempted to clean up your mess in http://trac.webkit.org/changeset/62576

If those expectations are not right, please correct them.

Insert nasty gram about running the tests before committing.

[Csaba Osztrogonác]

(In reply to comment #6)
> Committed <http://trac.webkit.org/changeset/62576>. This actually affected a number of tests!

Qt needed a fix after that, it landed in http://trac.webkit.org/changeset/62602

[Alexey Proskuryakov]

(In reply to comment #10)
> I attempted to clean up your mess in http://trac.webkit.org/changeset/62576

That was <http://trac.webkit.org/changeset/62629>.

Tiger is still broken, I'll investigate ASAP.

[Alexey Proskuryakov]

Fixed Tiger results in <http://trac.webkit.org/changeset/62684> (they are wrong, but not terribly so, and we can't do anything about that anyway).