| Summary: | Implement the HTML5 <mark> element. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Beverloo <peter> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, mike | ||||||
| Priority: | P2 | Keywords: | HTML5 | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 32934 | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 59629 [details]
Proposed patch
Code change looks great! The one thing missing here is a regression test. Take a look at LayoutTests/fast/html for some tests for revently added HTML5 elements. r- for the lack of test, please resubmit with a test case.
Created attachment 60343 [details]
Patch + Regression tests
Added a regression test for the element.
Comment on attachment 60343 [details]
Patch + Regression tests
r=me
Comment on attachment 60343 [details] Patch + Regression tests Clearing flags on attachment: 60343 Committed r62398: <http://trac.webkit.org/changeset/62398> All reviewed patches have been landed. Closing bug. |
Created attachment 59629 [details] Proposed patch This patch adds support for the HTML5 <mark> element to WebKit. The default style has been based on the current behavior of searching in Chrome, as well as on Mozilla's implementation of the tag[1]. I'm not sure about how to add tests for this, if they are required, advice would be appreciated.