Bug 41144

Summary: Implement the HTML5 <mark> element.
Product: WebKit Reporter: Peter Beverloo <peter>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mike
Priority: P2 Keywords: HTML5
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32934    
Attachments:
Description Flags
Proposed patch
mjs: review-
Patch + Regression tests none

Description Peter Beverloo 2010-06-24 04:00:15 PDT
Created attachment 59629 [details]
Proposed patch

This patch adds support for the HTML5 <mark> element to WebKit.

The default style has been based on the current behavior of searching in Chrome, as well as on Mozilla's implementation of the tag[1].

I'm not sure about how to add tests for this, if they are required, advice would be appreciated.
Comment 1 Maciej Stachowiak 2010-07-01 13:28:16 PDT
Comment on attachment 59629 [details]
Proposed patch

Code change looks great! The one thing missing here is a regression test. Take a look at LayoutTests/fast/html for some tests for revently added HTML5 elements. r- for the lack of test, please resubmit with a test case.
Comment 2 Peter Beverloo 2010-07-02 00:14:43 PDT
Created attachment 60343 [details]
Patch + Regression tests

Added a regression test for the element.
Comment 3 Maciej Stachowiak 2010-07-02 12:13:34 PDT
Comment on attachment 60343 [details]
Patch + Regression tests

r=me
Comment 4 WebKit Commit Bot 2010-07-02 12:45:40 PDT
Comment on attachment 60343 [details]
Patch + Regression tests

Clearing flags on attachment: 60343

Committed r62398: <http://trac.webkit.org/changeset/62398>
Comment 5 WebKit Commit Bot 2010-07-02 12:45:44 PDT
All reviewed patches have been landed.  Closing bug.