Bug 41109

Summary: [GTK] Separate DerivedSources per-project
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Separate DerivedSources per-project
none
Patch also touching webkitmarshal.list gustavo: review+

Martin Robinson
Reported 2010-06-23 15:26:56 PDT
When other ports are building, they build auto-generated sources for different components in different directories. This is the first step toward compiling against the framework style includes in WebKit2. For instance, currently all auto-generated sources are built in either WebKitBuild/Release/DerivedSources or WebKitBuild/Release/DerivedSources/webkit. I propose we generate sources in WebKitBuild/Release/DerivedSource/JavaScriptCore, WebKitBuild/Release/DerivedSource/WebCore, and WebKitBuild/Release/DerivedSource/webkit. The final path is required, since webkitgtk includes look like "#include <webkit/file.h>."
Attachments
Separate DerivedSources per-project (29.34 KB, patch)
2010-06-23 15:38 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch also touching webkitmarshal.list (30.40 KB, patch)
2010-06-24 08:50 PDT, Martin Robinson 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-06-23 15:38:14 PDT
Created attachment 59569 [details] Separate DerivedSources per-project
WebKit Review Bot
Comment 2 2010-06-23 20:08:12 PDT
Attachment 59569 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3336666
Martin Robinson
Comment 3 2010-06-23 20:26:55 PDT
It looks like this broke because the automake didn't rebuild webkit-marshall.cpp. I'll post a new patch tomorrow which touches webkitmarshal.list to force the rebuild.
Martin Robinson
Comment 4 2010-06-24 08:50:50 PDT
Created attachment 59659 [details] Patch also touching webkitmarshal.list
Gustavo Noronha (kov)
Comment 5 2010-07-01 13:00:50 PDT
Comment on attachment 59659 [details] Patch also touching webkitmarshal.list *headache*
Martin Robinson
Comment 6 2010-07-02 09:53:23 PDT
Committed r62387: <http://trac.webkit.org/changeset/62387>
Note You need to log in before you can comment on or make changes to this bug.