Bug 41093 – fast/text/hyphenate-character.html is failing on the Leopard Commit Bot

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

fast/text/hyphenate-character.html is failing on the Leopard Commit Bot

--- /tmp/layout-test-results/fast/text/hyphenate-character-expected.txt 2010-06-23 12:23:52.000000000 -0700
+++ /tmp/layout-test-results/fast/text/hyphenate-character-actual.txt   2010-06-23 12:23:52.000000000 -0700
@@ -17,18 +17,17 @@
           RenderText {#text} at (7,7) size 330x220
             text run at (7,7) width 245: "The chief difficulty Alice found"
             text run at (7,29) width 245: "at first was in managing her"
-            text run at (7,51) width 245: "flamingo: she succeeded in get"
-            text run at (7,73) width 208: "ting its body tucked away, "
-            text run at (215,73) width 37: "com"
-            text run at (7,95) width 245: "fortably enough, under her arm,"
-            text run at (7,117) width 226: "with its legs hanging down, "
-            text run at (233,117) width 104: "but generally,"
-            text run at (7,139) width 330: "just as she had got its neck nicely straight"
-            text run at (7,161) width 41: "ened "
-            text run at (48,161) width 289: "out, and was going to give the hedge"
-            text run at (7,183) width 204: "hog a blow with its head, it "
-            text run at (211,183) width 126: "would twist itself"
-            text run at (7,205) width 233: "round and look up in her face\x{2026}"
+            text run at (7,51) width 245: "flamingo: she succeeded in"
+            text run at (7,73) width 245: "getting its body tucked away,"
+            text run at (7,95) width 245: "comfortably enough, under her"
+            text run at (7,117) width 307: "arm, with its legs hanging down, "
+            text run at (314,117) width 23: "but"
+            text run at (7,139) width 330: "generally, just as she had got its neck nicely"
+            text run at (7,161) width 95: "straightened "
+            text run at (102,161) width 235: "out, and was going to give the"
+            text run at (7,183) width 285: "hedgehog a blow with its head, it "
+            text run at (292,183) width 45: "would"
+            text run at (7,205) width 314: "twist itself round and look up in her face\x{2026}"
       RenderBlock (floating) {DIV} at (356,0) size 344x284
         RenderBlock {P} at (0,16) size 344x18
           RenderText {#text} at (0,0) size 81x18
@@ -43,18 +42,17 @@
           RenderText {#text} at (7,7) size 330x220
             text run at (7,7) width 245: "The chief difficulty Alice found"
             text run at (7,29) width 245: "at first was in managing her"
-            text run at (7,51) width 245: "flamingo: she succeeded in get"
-            text run at (7,73) width 208: "ting its body tucked away, "
-            text run at (215,73) width 37: "com"
-            text run at (7,95) width 245: "fortably enough, under her arm,"
-            text run at (7,117) width 226: "with its legs hanging down, "
-            text run at (233,117) width 104: "but generally,"
-            text run at (7,139) width 330: "just as she had got its neck nicely straight"
-            text run at (7,161) width 41: "ened "
-            text run at (48,161) width 289: "out, and was going to give the hedge"
-            text run at (7,183) width 204: "hog a blow with its head, it "
-            text run at (211,183) width 126: "would twist itself"
-            text run at (7,205) width 233: "round and look up in her face\x{2026}"
+            text run at (7,51) width 245: "flamingo: she succeeded in"
+            text run at (7,73) width 245: "getting its body tucked away,"
+            text run at (7,95) width 245: "comfortably enough, under her"
+            text run at (7,117) width 307: "arm, with its legs hanging down, "
+            text run at (314,117) width 23: "but"
+            text run at (7,139) width 330: "generally, just as she had got its neck nicely"
+            text run at (7,161) width 95: "straightened "
+            text run at (102,161) width 235: "out, and was going to give the"
+            text run at (7,183) width 285: "hedgehog a blow with its head, it "
+            text run at (292,183) width 45: "would"
+            text run at (7,205) width 314: "twist itself round and look up in her face\x{2026}"
       RenderBlock (floating) {DIV} at (4,284) size 344x284
         RenderBlock {P} at (0,16) size 344x18
           RenderText {#text} at (0,0) size 47x18

.. and more.

I suspect that this depends on a special font?

[Eric Seidel (no email)]

The bot is Leopard:
ProductVersion:	10.5.8
BuildVersion:	9L31a

It doesn't have Safari 5 on it yet, but I can add it if that would fix the issue.

[Eric Seidel (no email)]

Anyway, we now know why the commit-queue hasn't committed anything in the last 48 hours. :)

It appears that hyphenation is not taking place on Leopard.

[Eric Seidel (no email)]

I would expect the other Leopard bots to be failing too though, no?

(In reply to comment #4)
> I would expect the other Leopard bots to be failing too though, no?

If they’re not, then my next guess would be that the machine where it’s failing is configured differently. Specifically, hyphenation will not happen unless the topmost language in System Preferences > International (as I think it was called on Leopard) > Language is not English.

From the command line, a way to get the language preference is

defaults read -g AppleLanguages

"en" should be the first element in the array for hyphenation to work.

[Eric Seidel (no email)]

I don't see any hyphenate tests listed in either:
http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac-leopard/Skipped
or
http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/Skipped

So I suspect the other leopard bots must be running them and passing them.


% read -g AppleLanguages
2010-06-23 13:01:08.222 defaults[87738:10b] 
The domain/default pair of (kCFPreferencesAnyApplication, AppleLanguages) does not exist

Looks like we already set AppleLanguages during DRT execution anyway:
http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L391


I'm happy to get you any other information you might need from the machine.

(In reply to comment #7)
> Looks like we already set AppleLanguages during DRT execution anyway:
> http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L391

Then I have no idea why it’s failing. Are you able to run a GUI session on that machine?

[Eric Seidel (no email)]

Yup.  I even have physical access to the machine if needed.  Normally I VNC or SSH to it though.

[Eric Seidel (no email)]

I'm forcing the machine to do a clean build in case that helps.

[Adam Barth]

I've seen similar failures on snow leopard with safari 5 installed

> Yup.  I even have physical access to the machine if needed.  Normally I VNC or SSH to it though.

Thing I would try then are: see if hyphenation ever occurs in Safari using a nightly build and specifying  "-webkit-hyphens: auto"; see if hyphenation ever occurs in the system, using TextEdit and selecting Enable Hyphenation.

[Eric Seidel (no email)]

FYI, the commit-queue is run inside a GUI session (otherwise DRT has kittens).

[Eric Seidel (no email)]

On the Commit Bot, over VNC: I pasted "getting" about 1000 times in a TextEdit doc, and it hyphenated when I made the window small enough (I would have expected it to hyphenate at larger window sizes, but it didn't seem to).

(In reply to comment #7)
> % read -g AppleLanguages
> 2010-06-23 13:01:08.222 defaults[87738:10b] 
> The domain/default pair of (kCFPreferencesAnyApplication, AppleLanguages) does not exist
> 
> Looks like we already set AppleLanguages during DRT execution anyway:
> http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L391

Looking more carefully at the WebKit code <http://trac.webkit.org/browser/trunk/WebCore/platform/text/mac/TextBreakIteratorInternalICUMac.mm#L39>, I can see that the default has to be set in the global domain, so what DumpRenderTree does is ineffective here. I bet

defaults write -g AppleLanguages -array en

will fix it.

[Eric Seidel (no email)]

On both my local SL box, as well as on the commit bot, I tested the following example:

<body style="-webkit-hyphens: auto;">
getting getting getting getting (repeated 1000 or so times)

I used r61670.dmg">http://builds.nightly.webkit.org/files/trunk/mac/WebKit-SVN-r61670.dmg

On my local SL box, hyphenation worked.  On the Commit Bot it never hyphenated.  So it seems to be a problem specific to webkit, since TextEdit on the Commit Bot was able to hyphenate.

Please try setting the default in the global domain.

[Eric Seidel (no email)]

(Sorry my previous comment was composed before I read your global domain stuff.  Silly bugzilla.)

Yup!  "defaults write -g AppleLanguages -array en" fixed it on the Commit Bot.

Now I guess we just need to fix the DRT/WebKit code to play nice together.

[Alexey Proskuryakov]

I don't think that forcing a particular language is a good thing to do in DRT long-term. It's good to test different code paths, even if only some developers can do that. We were getting a lot of good bug reports from different time zones, and I think that the same applies to languages.

Also long term, I don't see why English text shouldn't be hyphenated on my machine with primary Russian language.

Created attachment 64808 [details]
Specify the locale for hyphenation in the test

Fixed in <http://trac.webkit.org/projects/webkit/changeset/65652>.

[Eric Seidel (no email)]

Thank you mitz!