Bug 41073

Summary:

WebKit2: Flesh out more of the InjectedBundle client API

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebKit API

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	andersca: review+

Sam Weinig

Reported 2010-06-23 08:33:42 PDT

We should flesh out more of the InjectedBundle client APIs.

Attachments
patch (20.97 KB, patch) 2010-06-23 08:36 PDT, Sam Weinig	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2010-06-23 08:36:05 PDT

Created attachment 59518 [details] patch

Anders Carlsson

Comment 2 2010-06-23 08:38:00 PDT

Comment on attachment 59518 [details] patch r=me

WebKit Review Bot

Comment 3 2010-06-23 08:38:07 PDT

Attachment 59518 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.h:45: Extra space between WKBundleWillDestroyPageCallback and willDestroyPage [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:50: Extra space between WKBundlePageDidStartProvisionalLoadForFrameCallback and didStartProvisionalLoadForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:51: Extra space between WKBundlePageDidReceiveServerRedirectForProvisionalLoadForFrameCallback and didReceiveServerRedirectForProvisionalLoadForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:52: Extra space between WKBundlePageDidFailProvisionalLoadWithErrorForFrameCallback and didFailProvisionalLoadWithErrorForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:53: Extra space between WKBundlePageDidCommitLoadForFrameCallback and didCommitLoadForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:54: Extra space between WKBundlePageDidFinishLoadForFrameCallback and didFinishLoadForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:55: Extra space between WKBundlePageDidFailLoadWithErrorForFrameCallback and didFailLoadWithErrorForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:56: Extra space between WKBundlePageDidReceiveTitleForFrameCallback and didReceiveTitleForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:57: Extra space between WKBundlePageDidClearWindowObjectForFrameCallback and didClearWindowObjectForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/InjectedBundlePageClient.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 10 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 4 2010-06-23 09:07:06 PDT

Landed in r61689.

Note You need to log in before you can comment on or make changes to this bug.