Bug 41070

Summary: Web Inspector: InspectorController should be added only once as ScriptDebugListener
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bweinstein, eric, joepeck, keishi, pfeldman, pmuellr, podivilov, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Yury Semikhatsky
Reported 2010-06-23 07:20:34 PDT
InspectorController should be added only once as ScriptDebugListener to ScriptDebugServer. Now its added twice if debugger is always enebled: first time when InspectorController::connectFrontend is invoked and second time when ScriptsPanel is shown and InspectorController::enableDebuggerFromFrontend is called second time from there.
Attachments
Patch (3.45 KB, patch)
2010-06-23 07:30 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-06-23 07:30:36 PDT
Created attachment 59512 [details] Patch
Yury Semikhatsky
Comment 2 2010-06-23 08:34:31 PDT
Comment on attachment 59512 [details] Patch Clearing flags on attachment: 59512 Committed r61688: <http://trac.webkit.org/changeset/61688>
Yury Semikhatsky
Comment 3 2010-06-23 08:34:41 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-06-23 09:04:55 PDT
http://trac.webkit.org/changeset/61688 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.