| Summary: | :before/:after content should not become part of a ruby base | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roland Steiner <rolandsteiner> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Roland Steiner <rolandsteiner> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | rolandsteiner | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 40895 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 60847 [details]
patch - explicitly handle generated content
Created attachment 60998 [details]
patch - explicitly handle generated content (skip on gtk & qt)
Addendum to patch: No Windows baseline for the new test yet. (Also, please note that I will be away for the next 2 weeks on vacation and can't respond immediately to reviews and queries.) Created attachment 66477 [details]
Patch
Uploaded a new patch that subsumes the fix from https://bugs.webkit.org/show_bug.cgi?id=43722. Since this changes the code that was added by that patch I think I should request a new review. Also, extended the layout test from 43722 to also test for floated ruby elements (making them block elements) and adding a similar test for :after content. |
Created attachment 59475 [details] test case Text content generated by :before and :after selectors should not become part of any annotated ruby base. I.e., for <ruby>base<rt>text</rt></ruby>, "text" should annotate only/exatly "base", regardless whether there is additional :before or :after content. Added a test case.