Bug 40992

Summary:

Web Inspector: Several CPU profiles with the same name are displayed strangely on UI

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
a screenshot	none
patch	pfeldman: review+

Mikhail Naganov

Reported 2010-06-22 09:57:25 PDT

Created attachment 59382 [details] a screenshot Having a simple page that creates two profiles the same name: <html> <head> <script> function load() { console.profile("aaa"); console.profileEnd("aaa"); console.profile("aaa"); console.profileEnd("aaa"); } </script> </head> <body onload="load()"> </body> </html> In Inspector, they are displayed pretty strangely, see the screenshot. If I reload the page, new profiles are added to the first "aaa" item, as "Run 3", "Run 4", and so forth. I believe, the first two should be displayed as "Run 1" and "Run 2", not as separate items.

Attachments
a screenshot (10.99 KB, image/png) 2010-06-22 09:57 PDT, Mikhail Naganov	no flags	Details
patch (1.25 KB, patch) 2010-06-23 04:57 PDT, Mikhail Naganov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2010-06-23 04:57:15 PDT

Created attachment 59503 [details] patch

Mikhail Naganov

Comment 2 2010-06-23 05:28:18 PDT

Manually committed http://trac.webkit.org/changeset/61682 2010-06-23 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Fix displaying of several CPU profiles with the same name. https://bugs.webkit.org/show_bug.cgi?id=40992 * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):

Note You need to log in before you can comment on or make changes to this bug.