Bug 40988

Summary: Web Inspector: move nodeByPath from InjectedScript to InspectorBackend.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, rik, timothy, tkent, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change. yurys: review+

Description Pavel Feldman 2010-06-22 08:42:36 PDT
Patch to follow. My goal is to get rid of InjectedScriptAccess in favor of more clear InspectorBackend.idl interface.
Comment 1 Pavel Feldman 2010-06-22 08:43:56 PDT
Created attachment 59374 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2010-06-22 08:48:53 PDT
Comment on attachment 59374 [details]
[PATCH] Proposed change.

WebCore/inspector/InspectorFrontend.cpp: 
 +  
Please return this line.
Comment 3 Pavel Feldman 2010-06-22 22:17:20 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InjectedScriptHost.cpp
	M	WebCore/inspector/InjectedScriptHost.h
	M	WebCore/inspector/InjectedScriptHost.idl
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorBackend.idl
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/InjectedScriptAccess.js
Committed r61655
Comment 4 Kent Tamura 2010-06-22 23:02:57 PDT
This change made many inspector tests failing on Chromium:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#useWebKitCanary=true&tests=http%2Ftests%2Floading%2Fbad-scheme-subframe.html%2Chttp%2Ftests%2Finspector%2Fresource-parameters.html%2Cinspector%2Faudits-panel-functional.html%2Cinspector%2Fconsole-clear.html%2Cinspector%2Fconsole-dir-global.html%2Cinspector%2Fconsole-dir.html%2Cinspector%2Fconsole-dirxml.html%2Cinspector%2Fconsole-log-before-inspector-open.html%2Cinspector%2Fconsole-tests.html%2Cinspector%2Fcookie-resource-match.html%2Cinspector%2Felements-img-tooltip.html%2Cinspector%2Felements-panel-limited-children.html%2Cinspector%2Felements-panel-rewrite-href.html%2Cinspector%2Felements-panel-search.html%2Cinspector%2Felements-panel-selection-on-refresh.html%2Cinspector%2Felements-panel-structure.html%2Cinspector%2Felements-panel-styles.html%2Cinspector%2Felements-panel-xhtml-structure.xhtml%2Cinspector%2Fevaluate-in-frontend.html%2Cinspector%2Finspected-objects-not-overriden.html%2Cinspector%2Fstyles-disable-inherited.html%2Cinspector%2Fstyles-disable-then-delete.html%2Cinspector%2Fstyles-disable-then-enable.html%2Cinspector%2Fstyles-iframe.html%2Cinspector%2Fstyles-source-lines.html%2Cinspector%2Fstyles-source-offsets.html%2Cinspector%2Fsyntax-highlight-css.html%2Cinspector%2Fsyntax-highlight-html.html%2Cinspector%2Fsyntax-highlight-javascript.html%2Cinspector%2Ftimeline-enum-stability.html%2Cinspector%2Ftimeline-event-dispatch.html%2Cinspector%2Ftimeline-layout.html%2Cinspector%2Ftimeline-mark-timeline.html%2Cinspector%2Ftimeline-network-resource.html%2Cinspector%2Ftimeline-paint.html%2Cinspector%2Ftimeline-parse-html.html%2Cinspector%2Ftimeline-recalculate-styles.html%2Cinspector%2Ftimeline-script-tag-1.html%2Cinspector%2Ftimeline-script-tag-2.html%2Cinspector%2Ftimeline-trivial.html
Comment 5 Pavel Feldman 2010-06-22 23:54:03 PDT
Fixed in r61659.