Bug 40987

Summary: [Chromium] Add a WebPlugin implementation using a WebView to draw.
Product: WebKit Reporter: Bernhard Bauer <bauerb>
Component: New BugsAssignee: Bernhard Bauer <bauerb>
Status: RESOLVED WONTFIX    
Severity: Normal CC: fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Adds WebDOMUIPlugin, WebDOMUIPluginClient and WebDOMUIPluginImpl. fishd: review-

Bernhard Bauer
Reported 2010-06-22 08:33:08 PDT
Click-to-load for blocked plugins is going to use this pseudo-plugin.
Attachments
Adds WebDOMUIPlugin, WebDOMUIPluginClient and WebDOMUIPluginImpl. (18.23 KB, patch)
2010-06-22 09:16 PDT, Bernhard Bauer 		fishd: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bernhard Bauer
Comment 1 2010-06-22 09:16:52 PDT
Created attachment 59379 [details] Adds WebDOMUIPlugin, WebDOMUIPluginClient and WebDOMUIPluginImpl.
Darin Fisher (:fishd, Google)
Comment 2 2010-06-22 10:24:06 PDT
Comment on attachment 59379 [details] Adds WebDOMUIPlugin, WebDOMUIPluginClient and WebDOMUIPluginImpl. I think this code (minus the changes to existing WebKit API interfaces) belongs in the chromium repository. The concept of DOM UI is a chromium thing. Am I missing a reason why this is best to have as part of the WebKit API?
Bernhard Bauer
Comment 3 2010-06-22 10:50:26 PDT
(In reply to comment #2) > (From update of attachment 59379 [details]) > I think this code (minus the changes to existing WebKit API interfaces) belongs > in the chromium repository. The concept of DOM UI is a chromium thing. > > Am I missing a reason why this is best to have as part of the WebKit API? The drawing code (getting a GraphicsContext from a WebCanvas and doing the necessary transformations on it) depends on WebKit code that's not publicly exposed. I tried keeping the changes to the public interface as small as possible though. I'm not really happy about the name WebDOMUIPlugin either, do you think something like WebViewPlugin would be better?
Darin Fisher (:fishd, Google)
Comment 4 2010-06-22 12:52:47 PDT
(In reply to comment #3) > The drawing code (getting a GraphicsContext from a WebCanvas and doing the > necessary transformations on it) depends on WebKit code that's not publicly > exposed. I tried keeping the changes to the public interface as small as > possible though. I see. I would imagine that it is possible to do the equivalent transforms using Skia/CG directly. > I'm not really happy about the name WebDOMUIPlugin either, do you think something like WebViewPlugin would be better? Yeah, WebViewPlugin would probably be better.
Stephen Chenney
Comment 5 2013-04-09 16:09:51 PDT
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.
Note You need to log in before you can comment on or make changes to this bug.