Bug 40972

Summary: Fix the Windows build bots
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch eric: review+, dumi: commit-queue-

Dumitru Daniliuc
Reported 2010-06-21 23:57:22 PDT
It looks like ImageDiff.vcproj is missing a dependency on JavaScriptCore.lib, which makes the Windows bots fail.
Attachments
patch (2.32 KB, patch)
2010-06-22 00:00 PDT, Dumitru Daniliuc 		eric: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2010-06-22 00:00:28 PDT
Created attachment 59345 [details] patch Should fix the Windows build, at least in a clean client.
Eric Seidel (no email)
Comment 2 2010-06-22 00:01:25 PDT
Comment on attachment 59345 [details] patch Looks sane to me.
Dumitru Daniliuc
Comment 3 2010-06-22 00:05:31 PDT
Landed as r61603. If you see anything wrong with this patch, please let me know and I'll be happy to fix the problem.
Adam Roben (:aroben)
Comment 4 2010-06-22 06:56:25 PDT
The patch looks fine. Thanks for fixing it! I wish we knew why this error started happening in the first place, though.
Adam Roben (:aroben)
Comment 5 2010-06-22 08:43:12 PDT
(In reply to comment #4) > I wish we knew why this error started happening in the first place, though. Looks like the culprit is <http://trac.webkit.org/changeset/61576>, which must have caused FastMalloc.h to get pulled into ImageDiff.
Adam Roben (:aroben)
Comment 6 2010-06-22 08:46:40 PDT
Another option would have been to define USE_SYSTEM_MALLOC=1.
Note You need to log in before you can comment on or make changes to this bug.