Bug 40972

Summary: Fix the Windows build bots
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch eric: review+, dumi: commit-queue-

Description Dumitru Daniliuc 2010-06-21 23:57:22 PDT 
It looks like ImageDiff.vcproj is missing a dependency on JavaScriptCore.lib, which makes the Windows bots fail.
Comment 1 Dumitru Daniliuc 2010-06-22 00:00:28 PDT 
Created attachment 59345 [details]
patch

Should fix the Windows build, at least in a clean client.
Comment 2 Eric Seidel (no email) 2010-06-22 00:01:25 PDT 
Comment on attachment 59345 [details]
patch

Looks sane to me.
Comment 3 Dumitru Daniliuc 2010-06-22 00:05:31 PDT 
Landed as r61603.

If you see anything wrong with this patch, please let me know and I'll be happy to fix the problem.
Comment 4 Adam Roben (:aroben) 2010-06-22 06:56:25 PDT 
The patch looks fine. Thanks for fixing it!

I wish we knew why this error started happening in the first place, though.
Comment 5 Adam Roben (:aroben) 2010-06-22 08:43:12 PDT 
(In reply to comment #4)
> I wish we knew why this error started happening in the first place, though.

Looks like the culprit is <http://trac.webkit.org/changeset/61576>, which must have caused FastMalloc.h to get pulled into ImageDiff.
Comment 6 Adam Roben (:aroben) 2010-06-22 08:46:40 PDT 
Another option would have been to define USE_SYSTEM_MALLOC=1.