Bug 40941
| Summary: | check-webkit-style falsely thinks template struct declaration is two statements | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | John Sullivan <sullivan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
John Sullivan
From the patch for <https://bugs.webkit.org/show_bug.cgi?id=40938>, check-webkit-style complained about this line:
template<typename P> struct DefaultHash<RetainPtr<P> > { typedef PtrHash<RetainPtr<P> > Hash; };
The complaint was:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/wtf/RetainPtr.h:219: More than one command on the same line [whitespace/newline] [4]
This is a false positive; there are not multiple commands on that line (though there are two semicolons).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |