Summary: | [CMake] Remove unused variable in EFL build system | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas De Marchi <lucas.de.marchi> | ||||
Component: | WebKit Misc. | Assignee: | Lucas De Marchi <lucas.de.marchi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barbieri, commit-queue, leandro, lucas.de.marchi | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Lucas De Marchi
2010-06-21 11:56:22 PDT
Created attachment 59270 [details]
Patch
I'm not a reviewer, this is an informal review. LGTM. Comment on attachment 59270 [details]
Patch
IMO Leandro should commit these build fixes with no or just informal review, for you. Build changes only need review if they are changing something in the way the build works, or how the library is built, or affecting other ports. Build fixes should be just committed.
Comment on attachment 59270 [details] Patch Clearing flags on attachment: 59270 Committed r61852: <http://trac.webkit.org/changeset/61852> All reviewed patches have been landed. Closing bug. |