Bug 40931

Summary: [CMake] Remove unused variable in EFL build system
Product: WebKit Reporter: Lucas De Marchi <lucas.de.marchi>
Component: WebKit Misc.Assignee: Lucas De Marchi <lucas.de.marchi>
Status: RESOLVED FIXED    
Severity: Normal CC: barbieri, commit-queue, leandro, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Lucas De Marchi
Reported 2010-06-21 11:56:22 PDT
[CMake] Remove unused variable in EFL build system
Attachments
Patch (1.28 KB, patch)
2010-06-21 11:58 PDT, Lucas De Marchi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lucas De Marchi
Comment 1 2010-06-21 11:58:27 PDT
Created attachment 59270 [details] Patch
Leandro Pereira
Comment 2 2010-06-21 13:39:29 PDT
I'm not a reviewer, this is an informal review. LGTM.
Gustavo Noronha (kov)
Comment 3 2010-06-23 07:19:06 PDT
Comment on attachment 59270 [details] Patch IMO Leandro should commit these build fixes with no or just informal review, for you. Build changes only need review if they are changing something in the way the build works, or how the library is built, or affecting other ports. Build fixes should be just committed.
WebKit Commit Bot
Comment 4 2010-06-25 05:13:35 PDT
Comment on attachment 59270 [details] Patch Clearing flags on attachment: 59270 Committed r61852: <http://trac.webkit.org/changeset/61852>
WebKit Commit Bot
Comment 5 2010-06-25 05:13:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.