Summary: | Speech Input: Add a speech button to text input element (no rendering or actions yet) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Satish Sampath <satish> | ||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, jorlow, satish, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 39485 | ||||||||
Attachments: |
|
Description
Satish Sampath
2010-06-21 09:30:13 PDT
Created attachment 59261 [details]
Patch
Patch
Comment on attachment 59261 [details]
Patch
Drive by comment:
WebCore/rendering/TextControlInnerElements.cpp:322
+ return new InputFieldSpeechButtonElement(document);
ADOPT REF!!!!!!!!!!!!!!!!
This will cause a memory leak. Always remember to use adropRef with your ::create methods.
Comment on attachment 59261 [details] Patch > @@ -1,5 +1,60 @@ > 2010-06-21 Satish Sampath <satish@chromium.org> > > + Reviewed by NOBODY (OOPS!). This form of ChangeLog diff makes a problem with commit queue. Please change the date of the new ChangeLog entry. WebCore/html/HTMLInputElement.cpp:2830 + /* FIXME: Enable the following as the renderers are updated to include speech UI. Do not have commented-out code. WebCore/html/HTMLInputElement.cpp:2842 + default: Do not use "default" for inputType(). Created attachment 59376 [details]
Addresses Kent & Jeremy's comments
Comment on attachment 59376 [details]
Addresses Kent & Jeremy's comments
Looks OK.
Comment on attachment 59376 [details] Addresses Kent & Jeremy's comments Clearing flags on attachment: 59376 Committed r61752: <http://trac.webkit.org/changeset/61752> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/61752 might have broken Chromium Mac Release |