Bug 40900

Summary: [EFL] Build break for r61527
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hyuki.kim, joone, leandro, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
patch for build break none

Gyuyoung Kim
Reported 2010-06-20 22:04:46 PDT
There is a build break for WebKitEFL. [100%] Building C object WebKit/CMakeFiles/../Programs/EWebLauncher.dir/efl/EWebLauncher/main.c.o Linking CXX executable ../Programs/EWebLauncher libewebkit.so: undefined reference to `WebCore::FormSubmission::create(WebCore::FormSubmission::Method, WebCore::String const&, WebCore::String const&, WebCore::String const&, WTF::PassRefPtr<WebCore::FormState>, WTF::PassRefPtr<WebCore::FormData>, WebCore::String const&, bool, WTF::PassRefPtr<WebCore::Event>)' collect2: ld returned 1 exit status make[2]: *** [WebKit/../Programs/EWebLauncher] error 1 It seems to me that this errors comes from Bug 40084 - Introduce FormSubmission, the structure representing a form submission. (https://bugs.webkit.org/show_bug.cgi?id=40084) The bug's patch didn't consider cmake.
Attachments
patch for build break (957 bytes, patch)
2010-06-20 22:07 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2010-06-20 22:07:40 PDT
Created attachment 59225 [details] patch for build break I fixed this break.
Gyuyoung Kim
Comment 2 2010-06-20 22:14:17 PDT
Wow, thank you for your fast review. :)
WebKit Commit Bot
Comment 3 2010-06-20 22:28:13 PDT
Comment on attachment 59225 [details] patch for build break Clearing flags on attachment: 59225 Committed r61528: <http://trac.webkit.org/changeset/61528>
WebKit Commit Bot
Comment 4 2010-06-20 22:28:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.