Bug 4087

Summary: Fixes function.cpp for Windows
Product: WebKit Reporter: Justin Haygood <jhaygood>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 3356    
Attachments:
Description Flags
Enables ICU, etc..
darin: review-
Assumes ICU throughout mjs: review+

Justin Haygood
Reported 2005-07-20 15:25:38 PDT
Fixes function.cpp for Windows, including enabling ICU support.
Attachments
Enables ICU, etc.. (957 bytes, patch)
2005-07-20 15:26 PDT, Justin Haygood 		darin: review-
DetailsFormatted DiffDiff
Assumes ICU throughout (819 bytes, patch)
2005-07-21 13:24 PDT, Justin Haygood 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Haygood
Comment 1 2005-07-20 15:26:05 PDT
Created attachment 3034 [details] Enables ICU, etc.. Enables ICU for Windows, etc..
Darin Adler
Comment 2 2005-07-21 13:06:01 PDT
Comment on attachment 3034 [details] Enables ICU, etc.. This HAVE_ICU logic should be moved to <config.h> so it doesn't have to be in every single file. In fact, I think we can just assume ICU -- we don't really need the non-ICU code path in JavaScriptCore. Either way, this patch should be fixed.
Justin Haygood
Comment 3 2005-07-21 13:17:15 PDT
(In reply to comment #2) > (From update of attachment 3034 [details] [edit]) > This HAVE_ICU logic should be moved to <config.h> so it doesn't have to be in > every single file. > > In fact, I think we can just assume ICU -- we don't really need the non-ICU > code path in JavaScriptCore. > > Either way, this patch should be fixed. > I'll fix it, wiping out the non ICU codepaths. Thank you though. That was what I **really** wanted to do, but just wanted to play it safe.
Justin Haygood
Comment 4 2005-07-21 13:24:27 PDT
Created attachment 3050 [details] Assumes ICU throughout Assumes that we have ICU everywhere.
Maciej Stachowiak
Comment 5 2005-07-24 17:13:26 PDT
Comment on attachment 3050 [details] Assumes ICU throughout r=me but I don't think this comment is really needed: +// Assume ICU
Darin Adler
Comment 6 2005-08-31 00:55:21 PDT
Sorry, these were sitting around in UNCONFIRMED so I didn't notice them. Landing them now.
Note You need to log in before you can comment on or make changes to this bug.