Bug 4085

Summary: Modify config.h to have options for Windows
Product: WebKit Reporter: Justin Haygood <jhaygood>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 3356    
Attachments:
Description Flags
Adds Windows options
darin: review-
Same changes as before, but consistent, and has HAVE_ICU darin: review+

Justin Haygood
Reported 2005-07-20 15:18:35 PDT
config.h needs to work on Windows. Patch to fix being attached to this bug.
Attachments
Adds Windows options (1.07 KB, patch)
2005-07-20 15:19 PDT, Justin Haygood 		darin: review-
DetailsFormatted DiffDiff
Same changes as before, but consistent, and has HAVE_ICU (1.08 KB, patch)
2005-07-22 10:50 PDT, Justin Haygood 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Haygood
Comment 1 2005-07-20 15:19:02 PDT
Created attachment 3032 [details] Adds Windows options Provides HAVE_BLABLABLA options for Windows
Justin Haygood
Comment 2 2005-07-20 15:19:54 PDT
Comment on attachment 3032 [details] Adds Windows options Adds Windows options to config.h
Darin Adler
Comment 3 2005-07-21 13:08:55 PDT
Comment on attachment 3032 [details] Adds Windows options This mixes "#ifndef WIN32" with #if WIN32". Should be made consistent. Otherwise, looks fine to me.
Justin Haygood
Comment 4 2005-07-22 10:50:09 PDT
Created attachment 3054 [details] Same changes as before, but consistent, and has HAVE_ICU Makes changes recommended to other bugs, and makes the WIN32 #ifs consistent.
Darin Adler
Comment 5 2005-07-22 23:05:19 PDT
Comment on attachment 3054 [details] Same changes as before, but consistent, and has HAVE_ICU Looks good. I'd prefer "#if !WIN32" to "#if! WIN32", but that's a nit at this point; we should land it.
Darin Adler
Comment 6 2005-08-31 00:55:21 PDT
Sorry, these were sitting around in UNCONFIRMED so I didn't notice them. Landing them now.
Note You need to log in before you can comment on or make changes to this bug.