Bug 40810 – [EFL] Build break on Debug build

• Component: New Bugs
• Status: RESOLVED FIXED

[Gyuyoung Kim]

I cannot found options related to DEBUG. In my opinion, EFLWebKit needs to enable debug option as well.

When I added ENABLE_DEBUG option to cmake/OptionsEfl.cmake, there were "undefined references" as below,

Conservative compression summary:
  Wrote total 47834 bytes (47Kb) from 134514 (131Kb) input data
  Output file is 35.6% the size of the input data
  Saved 86680 bytes (85Kb)
Raw compression summary:
  Wrote total 47834 bytes (47Kb) from 807076 (788Kb) raw input data
  Output file is 5.9% the size of the raw input data
  Saved 759242 bytes (741Kb)
Scanning dependencies of target EWebLauncher
[100%] Building C object WebKit/CMakeFiles/../Programs/EWebLauncher.dir/efl/EWebLauncher/main.c.o
Linking CXX executable ../Programs/EWebLauncher
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::CSSPreloadScanner(WebCore::Document*)'
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::scan(WebCore::HTML5Token const&, bool)'
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::reset()'
collect2: ld returned 1 exit status

There are no "html/CSSPreloadScanner.cpp / h" in WebCore/CMakeList.txt. I added them to WebCore/CMakeList.txt.

[Gyuyoung Kim]

Created attachment 59071 [details]
Patch for debug option

[Gyuyoung Kim]

  Wrote total 47834 bytes (47Kb) from 807076 (788Kb) raw input data
  Output file is 5.9% the size of the raw input data
  Saved 759242 bytes (741Kb)
Scanning dependencies of target EWebLauncher
[100%] Building C object WebKit/CMakeFiles/../Programs/EWebLauncher.dir/efl/EWebLauncher/main.c.o
Linking CXX executable ../Programs/EWebLauncher
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::CSSPreloadScanner(WebCore::Document*)'
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::scan(WebCore::HTML5Token const&, bool)'
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::reset()'
collect2: ld returned 1 exit status
make[2]: *** [WebKit/../Programs/EWebLauncher] error 1

[Gyuyoung Kim]

Created attachment 59075 [details]
patch for build break

It seems that lukas already made a patch for debug build as below,

Bug 40566 -  [EFL] Build system is forcing build type to Release
(https://bugs.webkit.org/show_bug.cgi?id=40566)

However, there are still build breaks when no Release build.

[100%] Building C object WebKit/CMakeFiles/../Programs/EWebLauncher.dir/efl/EWebLauncher/main.c.o
Linking CXX executable ../Programs/EWebLauncher
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::CSSPreloadScanner(WebCore::Document*)'
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::scan(WebCore::HTML5Token const&, bool)'
libewebkit.so: undefined reference to `WebCore::CSSPreloadScanner::reset()'
collect2: ld returned 1 exit status
make[2]: *** [WebKit/../Programs/EWebLauncher] error 1

[Lucas De Marchi]

The issue is fixed on r61163 and partially on r61323.

Now the only thing that is missing is on #40566. To enable debug it will suffice to do the following in a build directory:

cmake .. -DPORT=Efl -DCMAKE_BUILD_TYPE=Debug


For future updates on CMake, remember that we don't keep track of .h files since they are automatically detected at compilation time.

[Lucas De Marchi]

Ah, sorry about previous comment, I was cheated by the file name. This is another problem.

It has been broken again by r61366. I'm CCing Leandro who is able to fix this without going through commit queue.

[Leandro Pereira]

Looks good to me.

Just change the ChangeLog entry to "Reviewed by NOBODY (OOPS!)" to "Unreviewed build fix" and I'll land it.

[Leandro Pereira]

Comment on attachment 59075 [details]
patch for build break

Committed as r61416.

[WebKit Review Bot]

http://trac.webkit.org/changeset/61416 might have broken Qt Linux Release minimal
The following changes are on the blame list:
http://trac.webkit.org/changeset/61416
http://trac.webkit.org/changeset/61414
http://trac.webkit.org/changeset/61415

[Leandro Pereira]

(In reply to comment #8)
> http://trac.webkit.org/changeset/61416 might have broken Qt Linux Release minimal
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/61416
> http://trac.webkit.org/changeset/61414
> http://trac.webkit.org/changeset/61415


Looks like a false alarm.