Summary: | Update npapi.h for recent upstream changes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stuart Morgan <stuartmorgan> | ||||||||
Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, ap, joshmoz, menard, rakuco, sriram.neelakandan, webkit.review.bot, zoltan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 77200 | ||||||||||
Attachments: |
|
Description
Stuart Morgan
2010-06-17 09:35:45 PDT
Sounds good to me! Created attachment 137294 [details] Pull changes with respect to MOZ_X11 guard from official npapi-sdk This patch pulls in changes with respect to MOZ_X11 guard The changes are from r14@http://code.google.com/p/npapi-sdk/ may want to refer to discussion @ https://bugs.webkit.org/show_bug.cgi?id=18638; Comment 7 and above Also there are some changes to Makefile systems (.pri, .am and .cmake) files to ensure MOZ_X11 is passed along as required Comment on attachment 137294 [details]
Pull changes with respect to MOZ_X11 guard from official npapi-sdk
The patch wasn't applied to WebKit ToT. Please update the patch.
Created attachment 138057 [details]
previous patch updated to ToT
updated patch attached
Attachment 138057 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'GNUmakefile.am', u'Source/We..." exit_code: 1
Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 138064 [details]
updated patch with reason for why No New Tests
New Tests are not required. No functionality change. Only updating NPAPI header file with MOZ_X11 gaurd flag.
However, if MOZ_X11 is not passed, where required (assuming most ports are building with NPAPI enabled) build would break and EWS must catch it.
Please, Its all green now ! Can someone r+ and land this..before this gets outdated again ? Comment on attachment 138064 [details] updated patch with reason for why No New Tests Clearing flags on attachment: 138064 Committed r114869: <http://trac.webkit.org/changeset/114869> All reviewed patches have been landed. Closing bug. |