Bug 40744 – Rietveld review queue: Need a way to fetch patches to be processed

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Julie Parent]

We need a way to fetch all patches that need to be processed by the Rietveld queue.  This is all attachments, that are patches, that are not obsolete, that do not have in-rietveld set.

We tried to use the buglist interface, but this fails because it is at the bug level, not the patch level.  That is, if a bug has one patch that has in-rietveld+ and one patch that doesn't, we can't find it, since it matches the flags at the bug level.  (The query we were using was: https://bugs.webkit.org/buglist.cgi?query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=flagtypes.name&type0-0-0=notsubstring&value0-0-0=in-rietveld&field0-1-0=attachments.ispatch&type0-1-0=equals&value0-1-0=1).

Also tried to use the request queue interface, but this fails because it can find bugs with a flag set to any particular value (aka, we can find all bugs with in-rietveld+ via https://bugs.webkit.org/request.cgi?action=queue&product=&type=in-rietveld&group=type&status=%2B), but there is no way to find bugs with the flag not set.

[Julie Parent]

I think we'll need a way to do a custom query, that will look something like:

# Gets all attachment ids for attachements taht are not obsolete, are patches, have some flag set, and don't have in-rietveld set.
SELECT flags.attach_id FROM flags,attachments WHERE attachments.isobsolete = 0 and attachments.ispatch = 1 and flags.attach_id = attachments.attach_id and flags.attach_id not in (SELECT attach_id FROM flags,flagtypes WHERE  flags.type_id = flagtypes.id and flagtypes.name = "in-rietveld")

# Gets all attachment ids for attachments that are not obsolete, are patches, have no flag set.
SELECT attachments.attach_id FROM attachments WHERE attachments.isobsolete = 0 and attachments.ispatch = 1 and attachments.bug_id not in (SELECT bug_id FROM flags)

and we'll need to exclude any security bugs.

[Julie Parent]

To exclude security bugs, I think I need to do something like: http://trac.webkit.org/browser/trunk/BugsSite/request.cgi#L142

Does anyone who knows WebKit's bugzilla setup better know how security bugs are marked in the database?  (Or know of a way simpler way to do this in the first place?)

[William Siegrist]

Security bugs are just bugs against the Security product. You can limit searches to Product=WebKit.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> Security bugs are just bugs against the Security product. You can limit searches to Product=WebKit.

There is also a way to mark Product=WebKit bugs with a security bit as well.  I don't recall how that's stored in the schema, though.  Giving yourself security privileges on your test instance of Bugzilla may help.