Bug 40596 – Safari beach-balls loading large pages with HTML5 parser

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Safari beach-balls loading large pages with HTML5 parser

[Eric Seidel (no email)]

Created attachment 58724 [details]
Patch

[Eric Seidel (no email)]

Created attachment 58725 [details]
Patch

[Adam Barth]

Comment on attachment 58725 [details]
Patch

Minor nits.  Don't know how to test this code...  :(

WebCore/html/HTML5DocumentParser.cpp:51
 +  // FIXME: We would this to be 0.2. Historically .2 caused slowness on old machines.
0.2 / .2 consistency.

WebCore/html/HTML5DocumentParser.cpp:129
 +  bool HTML5DocumentParser::processingData() const
WTF.  Please add a FIXME to track this down and figure out what it does.

WebCore/html/HTML5DocumentParser.cpp:174
 +      session.processedTokens++;
prefix increment

WebCore/html/HTML5DocumentParser.cpp:192
 +              return;
This is supposed to be break, not return

WebCore/html/HTML5DocumentParser.cpp:220
 +  // FIXME: This belongs on Document.
Please add this to document.

WebCore/html/HTML5DocumentParser.cpp:230
 +      // HACK: If a layout is scheduled, wait again to let the layout timer run first.
Is this copied from the old document parser?

WebCore/html/HTML5DocumentParser.cpp:278
 +      SynchronousMode mode = isFromNetwork ? AllowYield : ForceSynchronous;
Please inline this into call site.

[Eric Seidel (no email)]

Created attachment 58730 [details]
Patch for landing

[Eric Seidel (no email)]

Created attachment 58731 [details]
Patch for landing

[Adam Barth]

Comment on attachment 58731 [details]
Patch for landing

Clearing flags on attachment: 58731

Committed r61165: <http://trac.webkit.org/changeset/61165>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/61165 might have broken Chromium Linux Release

[Adam Barth]

Missing an include.  Build a patch now.