Summary: | Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vicki Murley <vicki> | ||||||||||||
Component: | DOM | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||||||
Status: | VERIFIED FIXED | ||||||||||||||
Severity: | Normal | CC: | ddkilzer | ||||||||||||
Priority: | P2 | Keywords: | HasReduction, InRadar | ||||||||||||
Version: | 420+ | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.4 | ||||||||||||||
Attachments: |
|
Description
Vicki Murley
2005-07-18 14:06:15 PDT
Created attachment 3006 [details]
test case
This appears to be working in ToT for Subversion revision r12256. Created attachment 7027 [details]
Build WebKit r9638 on Mac OS X 10.4.5 with Xcode 2.2.1
In order to write a failing test case, I needed to build an older version of WebKit than what was available on the oldest nightly. (WebKit-CVS-2005-10-01 03-27-01 GMT.dmg did not exhibit this bug.)
This patch is what was required to build WebKit r9638 on Mac OS X 10.4.5 with Xcode 2.2.1. (I chose this revision because I thought r9639 might have fixed the problem, although this probably isn't the case after writing another test case.) Note that this patch includes the build fix from r9641 in WebKit/WebView.subproj/WebFrame.m.
Also note that there are "problems" when running this version of WebKit with Safari 2.0.3. Clicking links causes 100% CPU usage and closing windows simply doesn't work. However, it was sufficient to write a failing test case. I'm including it in case others want to duplicate the work.
Created attachment 7029 [details]
Patch v1 (test case only)
Patch with only test case and changelog entry. The bug was fixed between r9638 (2005-07-09) and the first nightly build (WebKit-CVS-2005-10-01 03-27-01 GMT.dmg).
Created attachment 7030 [details]
Test results output from r9638
Comment on attachment 7029 [details]
Patch v1 (test case only)
r=me
good to land this test
(In reply to comment #7) > I think it's r10084 that fixed this. I updated to r10083 and built WebKit. This revision still fails as seen in Attachment 7030 [details]. I updated to r10084 (actually r10086 since it had build fixes for r10084), rebuilt, and confirmed that this revision DID fix this bug! Created attachment 7085 [details] Patch to fix ChangeLog entry Fix LayoutTests/ChangeLog entry per information found in Comment 8. Does this matter? (In reply to comment #8) > I updated to r10084 (actually r10086 since it had build fixes for r10084), > rebuilt, and confirmed that this revision DID fix this bug! Revision r10084 fixed Bug 4313. Comment on attachment 7085 [details]
Patch to fix ChangeLog entry
No, it doesn't matter, but I guess we can fix this anyway.
Verified fixed (test checked into svn and passes on r13385). |