Bug 40543
| Summary: | return QWebElement& from QWebElement::setAttribute() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Piotr Dobrogost <pd> |
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Enhancement | CC: | kent.hansen, tonikitoo, vestbo |
| Priority: | P2 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Piotr Dobrogost
How about returning QWebElement& from QWebElement::setAttribute() to make chaining possible?
I guess other methods of QWebElement could take advantage from this change as well.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kent Hansen
Changing the return type is not binary compatible (see http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_return_type).
It could be done for Qt 5, though.
Tor Arne, what do you think? Was this considered in the API reviews?
Antonio Gomes
maybe RESOLVED - LATER instead of INVALID, so we can revisit it at some point?
Tor Arne Vestbø
Chaining was not considered a goal for this API, as in most cases a normal semi-colon and multiple statements does the same job and is more in line with Qt's existing APIs.
foo.setAttribute("foo", "bar");
foo.setAttribute("biz", "baz");