Bug 40543

Summary: return QWebElement& from QWebElement::setAttribute()
Product: WebKit Reporter: Piotr Dobrogost <pd>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Enhancement CC: kent.hansen, tonikitoo, vestbo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   

Description Piotr Dobrogost 2010-06-13 02:29:01 PDT
How about returning QWebElement& from QWebElement::setAttribute() to make chaining possible?
I guess other methods of QWebElement could take advantage from this change as well.
Comment 1 Kent Hansen 2010-06-15 11:07:45 PDT
Changing the return type is not binary compatible (see http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_return_type).
It could be done for Qt 5, though.
Tor Arne, what do you think? Was this considered in the API reviews?
Comment 2 Antonio Gomes 2010-06-15 17:17:38 PDT
maybe RESOLVED - LATER instead of INVALID, so we can revisit it at some point?
Comment 3 Tor Arne Vestbø 2010-06-16 02:12:21 PDT
Chaining was not considered a goal for this API, as in most cases a normal semi-colon and multiple statements does the same job and is more in line with Qt's existing APIs.

foo.setAttribute("foo", "bar");
foo.setAttribute("biz", "baz");