Bug 40535

Summary:

[Qt] GraphicsLayer: recaching images creates an unnecessary deep copy

Product:

WebKit

Reporter:

Noam Rosenthal <noam>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

commit-queue, hausmann

Priority:

Keywords:

Performance, Qt

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Noam Rosenthal 2010-06-12 20:19:21 PDT

Profiling on Mac with raster + QGLWidget shows repeating image copies.

Comment 1 Noam Rosenthal 2010-06-12 20:22:53 PDT

Created attachment 58575 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-06-12 20:35:54 PDT

Comment on attachment 58575 [details]
Patch

OK.  rs=me.

Comment 3 WebKit Commit Bot 2010-06-13 01:20:32 PDT

Comment on attachment 58575 [details]
Patch

Clearing flags on attachment: 58575

Committed r61086: <http://trac.webkit.org/changeset/61086>

Comment 4 WebKit Commit Bot 2010-06-13 01:20:38 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Simon Hausmann 2010-06-13 14:10:47 PDT

Revision r61086 cherry-picked into qtwebkit-2.0 with commit 661d414dc93f5f57352dbfd1600a67d5d5407b21