Bug 40506

Summary: getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, eric, oliver, simon.fraser, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch dglazkov: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-06-11 16:31:16 PDT
The new code added to getParameter in 40318 to support the new UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL parameters is buggy and causes test failures on some machines.
Attachments
Patch (4.06 KB, patch)
2010-06-11 16:40 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-06-11 16:40:10 PDT
Created attachment 58525 [details] Patch From the ChangeLog: Return the data members of WebGLRenderingContext for these parameter queries rather than asking OpenGL, which knows nothing about them.
Dimitri Glazkov (Google)
Comment 2 2010-06-11 16:42:13 PDT
Comment on attachment 58525 [details] Patch Whoops.
Kenneth Russell
Comment 3 2010-06-11 16:44:53 PDT
Committed r61046: <http://trac.webkit.org/changeset/61046>
Simon Fraser (smfr)
Comment 4 2010-06-11 17:29:21 PDT
fast/canvas/webgl/gl-get-calls.html is still failing.
Kenneth Russell
Comment 5 2010-06-11 18:17:39 PDT
(In reply to comment #4) > fast/canvas/webgl/gl-get-calls.html is still failing. Not from what I see on the buildbot console. I think the Leopard Intel Debug slave was lost while the buggy test was still checked in, but the other bots are now passing the test.
Note You need to log in before you can comment on or make changes to this bug.